Skip to content

Commit 423268c

Browse files
Gudahttmetamaskbotlegobeat
authored
chore: Update @metamask/signature-controller and related packages (#22861)
## **Description** The package `@metamask/signature-controller` has been updated from v6 to v12. Despite the large number of major version bumps, no code changes were required. All breaking changes were due to changes in peer dependencies, and to type changes. The package `@metamask/approval-controller` needed a patch bump to satisfy the peer dependency requirements of `@metamask-signature-controller`, and `@metamask/logging-controller` needed a major bump for the same reason. The only `LoggingController` breaking change was to the types, so again no changes required. Here are all of the changelogs for these bumps: * https://github.com/MetaMask/core/blob/main/packages/signature-controller/CHANGELOG.md * https://github.com/MetaMask/core/blob/main/packages/logging-controller/CHANGELOG.md#202 * https://github.com/MetaMask/core/blob/main/packages/approval-controller/CHANGELOG.md#512 ## **Related issues** N/A ## **Manual testing steps** N/A ## **Screenshots/Recordings** N/A ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [x] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
1 parent 3fa4cd6 commit 423268c

File tree

7 files changed

+95
-282
lines changed

7 files changed

+95
-282
lines changed

‎lavamoat/browserify/beta/policy.json‎

Lines changed: 12 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -736,8 +736,8 @@
736736
},
737737
"packages": {
738738
"@metamask/address-book-controller>@metamask/controller-utils>@metamask/utils": true,
739+
"@metamask/address-book-controller>@metamask/controller-utils>ethjs-unit": true,
739740
"@metamask/controller-utils>@spruceid/siwe-parser": true,
740-
"@metamask/logging-controller>@metamask/controller-utils>ethjs-unit": true,
741741
"browserify>buffer": true,
742742
"eslint>fast-deep-equal": true,
743743
"eth-ens-namehash": true,
@@ -757,6 +757,12 @@
757757
"superstruct": true
758758
}
759759
},
760+
"@metamask/address-book-controller>@metamask/controller-utils>ethjs-unit": {
761+
"packages": {
762+
"@metamask/ethjs>number-to-bn": true,
763+
"bn.js": true
764+
}
765+
},
760766
"@metamask/announcement-controller": {
761767
"packages": {
762768
"@metamask/base-controller": true
@@ -1465,24 +1471,10 @@
14651471
},
14661472
"@metamask/logging-controller": {
14671473
"packages": {
1468-
"@metamask/logging-controller>@metamask/base-controller": true,
1474+
"@metamask/base-controller": true,
14691475
"uuid": true
14701476
}
14711477
},
1472-
"@metamask/logging-controller>@metamask/base-controller": {
1473-
"globals": {
1474-
"setTimeout": true
1475-
},
1476-
"packages": {
1477-
"immer": true
1478-
}
1479-
},
1480-
"@metamask/logging-controller>@metamask/controller-utils>ethjs-unit": {
1481-
"packages": {
1482-
"@metamask/ethjs>number-to-bn": true,
1483-
"bn.js": true
1484-
}
1485-
},
14861478
"@metamask/logo": {
14871479
"globals": {
14881480
"addEventListener": true,
@@ -1792,42 +1784,17 @@
17921784
"console.info": true
17931785
},
17941786
"packages": {
1787+
"@metamask/base-controller": true,
1788+
"@metamask/controller-utils": true,
17951789
"@metamask/logging-controller": true,
17961790
"@metamask/message-manager": true,
1797-
"@metamask/signature-controller>@metamask/base-controller": true,
1798-
"@metamask/signature-controller>@metamask/controller-utils": true,
1791+
"@metamask/providers>@metamask/rpc-errors": true,
17991792
"browserify>buffer": true,
1800-
"eth-rpc-errors": true,
18011793
"ethereumjs-util": true,
18021794
"lodash": true,
18031795
"webpack>events": true
18041796
}
18051797
},
1806-
"@metamask/signature-controller>@metamask/base-controller": {
1807-
"globals": {
1808-
"setTimeout": true
1809-
},
1810-
"packages": {
1811-
"immer": true
1812-
}
1813-
},
1814-
"@metamask/signature-controller>@metamask/controller-utils": {
1815-
"globals": {
1816-
"URL": true,
1817-
"console.error": true,
1818-
"fetch": true,
1819-
"setTimeout": true
1820-
},
1821-
"packages": {
1822-
"@metamask/controller-utils>@spruceid/siwe-parser": true,
1823-
"@metamask/logging-controller>@metamask/controller-utils>ethjs-unit": true,
1824-
"@metamask/utils": true,
1825-
"browserify>buffer": true,
1826-
"eslint>fast-deep-equal": true,
1827-
"eth-ens-namehash": true,
1828-
"ethereumjs-util": true
1829-
}
1830-
},
18311798
"@metamask/smart-transactions-controller": {
18321799
"globals": {
18331800
"URLSearchParams": true,
@@ -1864,8 +1831,8 @@
18641831
"setTimeout": true
18651832
},
18661833
"packages": {
1834+
"@metamask/address-book-controller>@metamask/controller-utils>ethjs-unit": true,
18671835
"@metamask/controller-utils>@spruceid/siwe-parser": true,
1868-
"@metamask/logging-controller>@metamask/controller-utils>ethjs-unit": true,
18691836
"@metamask/utils": true,
18701837
"browserify>buffer": true,
18711838
"eslint>fast-deep-equal": true,

‎lavamoat/browserify/desktop/policy.json‎

Lines changed: 12 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -736,8 +736,8 @@
736736
},
737737
"packages": {
738738
"@metamask/address-book-controller>@metamask/controller-utils>@metamask/utils": true,
739+
"@metamask/address-book-controller>@metamask/controller-utils>ethjs-unit": true,
739740
"@metamask/controller-utils>@spruceid/siwe-parser": true,
740-
"@metamask/logging-controller>@metamask/controller-utils>ethjs-unit": true,
741741
"browserify>buffer": true,
742742
"eslint>fast-deep-equal": true,
743743
"eth-ens-namehash": true,
@@ -757,6 +757,12 @@
757757
"superstruct": true
758758
}
759759
},
760+
"@metamask/address-book-controller>@metamask/controller-utils>ethjs-unit": {
761+
"packages": {
762+
"@metamask/ethjs>number-to-bn": true,
763+
"bn.js": true
764+
}
765+
},
760766
"@metamask/announcement-controller": {
761767
"packages": {
762768
"@metamask/base-controller": true
@@ -1542,24 +1548,10 @@
15421548
},
15431549
"@metamask/logging-controller": {
15441550
"packages": {
1545-
"@metamask/logging-controller>@metamask/base-controller": true,
1551+
"@metamask/base-controller": true,
15461552
"uuid": true
15471553
}
15481554
},
1549-
"@metamask/logging-controller>@metamask/base-controller": {
1550-
"globals": {
1551-
"setTimeout": true
1552-
},
1553-
"packages": {
1554-
"immer": true
1555-
}
1556-
},
1557-
"@metamask/logging-controller>@metamask/controller-utils>ethjs-unit": {
1558-
"packages": {
1559-
"@metamask/ethjs>number-to-bn": true,
1560-
"bn.js": true
1561-
}
1562-
},
15631555
"@metamask/logo": {
15641556
"globals": {
15651557
"addEventListener": true,
@@ -1933,42 +1925,17 @@
19331925
"console.info": true
19341926
},
19351927
"packages": {
1928+
"@metamask/base-controller": true,
1929+
"@metamask/controller-utils": true,
19361930
"@metamask/logging-controller": true,
19371931
"@metamask/message-manager": true,
1938-
"@metamask/signature-controller>@metamask/base-controller": true,
1939-
"@metamask/signature-controller>@metamask/controller-utils": true,
1932+
"@metamask/providers>@metamask/rpc-errors": true,
19401933
"browserify>buffer": true,
1941-
"eth-rpc-errors": true,
19421934
"ethereumjs-util": true,
19431935
"lodash": true,
19441936
"webpack>events": true
19451937
}
19461938
},
1947-
"@metamask/signature-controller>@metamask/base-controller": {
1948-
"globals": {
1949-
"setTimeout": true
1950-
},
1951-
"packages": {
1952-
"immer": true
1953-
}
1954-
},
1955-
"@metamask/signature-controller>@metamask/controller-utils": {
1956-
"globals": {
1957-
"URL": true,
1958-
"console.error": true,
1959-
"fetch": true,
1960-
"setTimeout": true
1961-
},
1962-
"packages": {
1963-
"@metamask/controller-utils>@spruceid/siwe-parser": true,
1964-
"@metamask/logging-controller>@metamask/controller-utils>ethjs-unit": true,
1965-
"@metamask/utils": true,
1966-
"browserify>buffer": true,
1967-
"eslint>fast-deep-equal": true,
1968-
"eth-ens-namehash": true,
1969-
"ethereumjs-util": true
1970-
}
1971-
},
19721939
"@metamask/smart-transactions-controller": {
19731940
"globals": {
19741941
"URLSearchParams": true,
@@ -2005,8 +1972,8 @@
20051972
"setTimeout": true
20061973
},
20071974
"packages": {
1975+
"@metamask/address-book-controller>@metamask/controller-utils>ethjs-unit": true,
20081976
"@metamask/controller-utils>@spruceid/siwe-parser": true,
2009-
"@metamask/logging-controller>@metamask/controller-utils>ethjs-unit": true,
20101977
"@metamask/utils": true,
20111978
"browserify>buffer": true,
20121979
"eslint>fast-deep-equal": true,

‎lavamoat/browserify/flask/policy.json‎

Lines changed: 12 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -736,8 +736,8 @@
736736
},
737737
"packages": {
738738
"@metamask/address-book-controller>@metamask/controller-utils>@metamask/utils": true,
739+
"@metamask/address-book-controller>@metamask/controller-utils>ethjs-unit": true,
739740
"@metamask/controller-utils>@spruceid/siwe-parser": true,
740-
"@metamask/logging-controller>@metamask/controller-utils>ethjs-unit": true,
741741
"browserify>buffer": true,
742742
"eslint>fast-deep-equal": true,
743743
"eth-ens-namehash": true,
@@ -757,6 +757,12 @@
757757
"superstruct": true
758758
}
759759
},
760+
"@metamask/address-book-controller>@metamask/controller-utils>ethjs-unit": {
761+
"packages": {
762+
"@metamask/ethjs>number-to-bn": true,
763+
"bn.js": true
764+
}
765+
},
760766
"@metamask/announcement-controller": {
761767
"packages": {
762768
"@metamask/base-controller": true
@@ -1542,24 +1548,10 @@
15421548
},
15431549
"@metamask/logging-controller": {
15441550
"packages": {
1545-
"@metamask/logging-controller>@metamask/base-controller": true,
1551+
"@metamask/base-controller": true,
15461552
"uuid": true
15471553
}
15481554
},
1549-
"@metamask/logging-controller>@metamask/base-controller": {
1550-
"globals": {
1551-
"setTimeout": true
1552-
},
1553-
"packages": {
1554-
"immer": true
1555-
}
1556-
},
1557-
"@metamask/logging-controller>@metamask/controller-utils>ethjs-unit": {
1558-
"packages": {
1559-
"@metamask/ethjs>number-to-bn": true,
1560-
"bn.js": true
1561-
}
1562-
},
15631555
"@metamask/logo": {
15641556
"globals": {
15651557
"addEventListener": true,
@@ -1969,42 +1961,17 @@
19691961
"console.info": true
19701962
},
19711963
"packages": {
1964+
"@metamask/base-controller": true,
1965+
"@metamask/controller-utils": true,
19721966
"@metamask/logging-controller": true,
19731967
"@metamask/message-manager": true,
1974-
"@metamask/signature-controller>@metamask/base-controller": true,
1975-
"@metamask/signature-controller>@metamask/controller-utils": true,
1968+
"@metamask/providers>@metamask/rpc-errors": true,
19761969
"browserify>buffer": true,
1977-
"eth-rpc-errors": true,
19781970
"ethereumjs-util": true,
19791971
"lodash": true,
19801972
"webpack>events": true
19811973
}
19821974
},
1983-
"@metamask/signature-controller>@metamask/base-controller": {
1984-
"globals": {
1985-
"setTimeout": true
1986-
},
1987-
"packages": {
1988-
"immer": true
1989-
}
1990-
},
1991-
"@metamask/signature-controller>@metamask/controller-utils": {
1992-
"globals": {
1993-
"URL": true,
1994-
"console.error": true,
1995-
"fetch": true,
1996-
"setTimeout": true
1997-
},
1998-
"packages": {
1999-
"@metamask/controller-utils>@spruceid/siwe-parser": true,
2000-
"@metamask/logging-controller>@metamask/controller-utils>ethjs-unit": true,
2001-
"@metamask/utils": true,
2002-
"browserify>buffer": true,
2003-
"eslint>fast-deep-equal": true,
2004-
"eth-ens-namehash": true,
2005-
"ethereumjs-util": true
2006-
}
2007-
},
20081975
"@metamask/smart-transactions-controller": {
20091976
"globals": {
20101977
"URLSearchParams": true,
@@ -2041,8 +2008,8 @@
20412008
"setTimeout": true
20422009
},
20432010
"packages": {
2011+
"@metamask/address-book-controller>@metamask/controller-utils>ethjs-unit": true,
20442012
"@metamask/controller-utils>@spruceid/siwe-parser": true,
2045-
"@metamask/logging-controller>@metamask/controller-utils>ethjs-unit": true,
20462013
"@metamask/utils": true,
20472014
"browserify>buffer": true,
20482015
"eslint>fast-deep-equal": true,

0 commit comments

Comments
 (0)