fix: Blockaid send External Link Clicked metric for missing tx types

[digiwand]

Description

As mentioned in the related issue

"
not all instances of the BlockaidBannerAlert are firing the event.

instances supported:

• ui/components/app/signature-request/signature-request.js (eth_signTypedData versions V3 and V4)
• ui/components/app/transaction-alerts/transaction-alerts.js

instances not supported:

• ui/components/app/signature-request-original/signature-request-original.component.js
• ui/pages/confirm-approve/confirm-approve-content/confirm-approve-content.component.js
• ui/pages/token-allowance/token-allowance.js
• ui/components/app/signature-request-siwe/signature-request-siwe.js

"

This PR adds support to the missing instances.

Additionally:

• minor lint fixes - missing deps
• remove superfluous ONLY_INCLUDE_IF(blockaid) guardrails

Updates to the schema are being discussed. I am considering cleanup. These and tests will be implemented in a future PR.

Related issues

Fixes: #22667

Manual testing steps

1. Go to test-dapp
2. Use PPOM section to QA

• confirm approve - Approval BUSD
• confirm allowance - Set Approval For All

I was unable to reproduce the malicious SIWE and the non-v3 or non-v4 signTyped signatures

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [da3b015]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6, 7
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1253 ± 137 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	87	285	164	72	34
		domContentLoaded	9	188	64	72	34
		load	925	2127	1253	286	137
		domInteractive	9	188	64	72	34

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 1.74 KiB (0.02%)
• common: 0 Bytes (0.00%)

[digiwand]

merging this now since tests seem to be passing implying the related code should continue to work. QA'd some of the updates

note: I wasn't able to check the metrics for

malicious SIWE and the non-v3 or non-v4 signTyped signatures

we can keep an eye out for these

cc: @bschorchit @blackdevelopa @jpuri @seaona @segun