[Bug]: Blockaid "External Link Clicked" events are missing from certain transaction types

[digiwand]

What is this about?

This fixes the current implementation of our "External Link Clicked" events by adding the missing events for certain transactions

note: Plans to remove these "External Link Clicked" events are happening along with this PR to move the event into the transaction metric events.

https://github.com/MetaMask/MetaMask-planning/issues/1756#issuecomment-1894363798

[...] not all instances of the BlockaidBannerAlert are firing the event.

instances supported:
ui/components/app/signature-request/signature-request.js
ui/components/app/transaction-alerts/transaction-alerts.js

instances not supported:
ui/components/app/signature-request-original/signature-request-original.component.js
ui/pages/confirm-approve/confirm-approve-content/confirm-approve-content.component.js
ui/pages/token-allowance/token-allowance.js
ui/components/app/signature-request-siwe/signature-request-siwe.js

For more information about removing the event being handled here, see:

• https://consensys.slack.com/archives/C04C0F6SSJH/p1705940566399579?thread_ts=1705939654.166539&cid=C04C0F6SSJH

  If we have this as a property to transactions and signature events, I believe we don’t need to fire this as a separate event anymore.

• Issue to move metric and remove these external link clicked events

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

• Engineering (needed in most cases)
• Design
• Product
• QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
• Security
• Legal
• Marketing
• Management (please specify)
• Other (please specify)

References

No response