Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Bump semver #20235

Merged
merged 3 commits into from
Jul 28, 2023
Merged

deps: Bump semver #20235

merged 3 commits into from
Jul 28, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Jul 27, 2023 •
edited
Loading

Explanation

#20230 (comment)

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@legobeat legobeat requested a review from Mrtenz July 27, 2023 15:03
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat mentioned this pull request Jul 27, 2023
Merged
8 tasks
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Jul 27, 2023
Mrtenz
Mrtenz previously approved these changes Jul 27, 2023
View reviewed changes
@legobeat legobeat marked this pull request as ready for review July 27, 2023 23:20
@legobeat legobeat requested a review from a team as a code owner July 27, 2023 23:20
@legobeat legobeat changed the title devDeps: Bump semver deps: Bump semver Jul 27, 2023
@legobeat legobeat requested review from a team as code owners July 27, 2023 23:39
@legobeat legobeat requested a review from Mrtenz July 27, 2023 23:57
@legobeat legobeat requested a review from hmalik88 July 27, 2023 23:57
@Mrtenz Mrtenz merged commit 7013b60 into MetaMask:develop Jul 28, 2023
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

@GuillaumeRx GuillaumeRx GuillaumeRx approved these changes

@hmalik88 hmalik88 Awaiting requested review from hmalik88

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legobeat @Mrtenz @GuillaumeRx