Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASK] Bump Snaps packages #20230

Merged
merged 5 commits into from
Jul 28, 2023
Merged

[FLASK] Bump Snaps packages #20230

merged 5 commits into from
Jul 28, 2023

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Jul 27, 2023

Explanation

This bumps the Snaps packages to their latest versions, to add support for the new lifecycle hooks, and fix some audit findings.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@Mrtenz Mrtenz requested review from a team as code owners July 27, 2023 09:27
@Mrtenz
Copy link
Member Author

Mrtenz commented Jul 27, 2023

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

hmalik88
hmalik88 previously approved these changes Jul 27, 2023
@Mrtenz Mrtenz force-pushed the mrtenz/bump-snaps-packages branch from 740034d to daf1265 Compare July 27, 2023 13:53
@metamaskbot
Copy link
Collaborator

Builds ready [daf1265]
Page Load Metrics (1523 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint109157132136
domContentLoaded1399172815239345
load1399172815239345
domInteractive1399172815239345
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -21 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 759 Bytes (0.02%)

yarn.lock Outdated Show resolved Hide resolved
@legobeat legobeat mentioned this pull request Jul 27, 2023
8 tasks
@bowensanders
Copy link
Contributor

Manual QA pass ✅

@Mrtenz Mrtenz force-pushed the mrtenz/bump-snaps-packages branch from a586ab0 to 348eaf7 Compare July 28, 2023 09:07
@Mrtenz
Copy link
Member Author

Mrtenz commented Jul 28, 2023

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

No policy changes

@metamaskbot
Copy link
Collaborator

Builds ready [348eaf7]
Page Load Metrics (1591 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint105159132147
domContentLoaded1472186015919646
load1473186015919646
domInteractive1472186015919646
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 360 Bytes (0.01%)

@Mrtenz Mrtenz merged commit 01a3a5d into develop Jul 28, 2023
9 checks passed
@Mrtenz Mrtenz deleted the mrtenz/bump-snaps-packages branch July 28, 2023 09:52
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 28, 2023
@Gudahtt Gudahtt added the release-11.1.0 Issue or pull request that will be included in release 11.1.0 label Sep 19, 2023
@Gudahtt Gudahtt removed the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants