-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLASK] Bump Snaps packages #20230
Merged
Merged
[FLASK] Bump Snaps packages #20230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@metamaskbot update-policies |
Policies updated |
hmalik88
previously approved these changes
Jul 27, 2023
Mrtenz
force-pushed
the
mrtenz/bump-snaps-packages
branch
from
July 27, 2023 13:53
740034d
to
daf1265
Compare
Builds ready [daf1265]
Page Load Metrics (1523 ± 45 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
legobeat
reviewed
Jul 27, 2023
Manual QA pass ✅ |
Mrtenz
force-pushed
the
mrtenz/bump-snaps-packages
branch
from
July 28, 2023 09:07
daf1265
to
a586ab0
Compare
Mrtenz
force-pushed
the
mrtenz/bump-snaps-packages
branch
from
July 28, 2023 09:07
a586ab0
to
348eaf7
Compare
@metamaskbot update-policies |
No policy changes |
GuillaumeRx
reviewed
Jul 28, 2023
david0xd
approved these changes
Jul 28, 2023
Builds ready [348eaf7]
Page Load Metrics (1591 ± 46 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
GuillaumeRx
approved these changes
Jul 28, 2023
metamaskbot
added
the
release-10.36.0
Issue or pull request that will be included in release 10.36.0
label
Jul 28, 2023
Gudahtt
added
the
release-11.1.0
Issue or pull request that will be included in release 11.1.0
label
Sep 19, 2023
Gudahtt
removed
the
release-10.36.0
Issue or pull request that will be included in release 10.36.0
label
Sep 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This bumps the Snaps packages to their latest versions, to add support for the new lifecycle hooks, and fix some audit findings.
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.