Version 3.8.5 #1758
Merged
Version 3.8.5 #1758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danfinlay
approved these changes
Jul 11, 2017
segun
added a commit
that referenced
this pull request
Apr 17, 2024
## **Description** We should update content for: when ppom returns warning as response [](https://codespaces.new/MetaMask/metamask-extension/pull/24037?quickstart=1) ## **Related issues** Fixes: [#1758](https://github.com/MetaMask/MetaMask-planning/issues/1758) ## **Manual testing steps** 1. Add this custom network: https://base.drpc.org with chainId 8453 2. Trigger a transaction from the test dapp -- see error 3. For warning, you can edit the code to return a warning alert response and see the warning. ## **Screenshots/Recordings** ### **Before** <img width="353" alt="Screenshot 2024-04-15 at 22 37 08" src="https://github.com/MetaMask/metamask-extension/assets/44811/2572b1a5-233d-4e7e-83c3-5ea92faef362"> ### **After** <img width="337" alt="Screenshot 2024-04-15 at 22 36 21" src="https://github.com/MetaMask/metamask-extension/assets/44811/1e4ec760-3714-4a91-9e5b-e39784887354"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
pedronfigueiredo
added a commit
that referenced
this pull request
Jun 6, 2024
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR fixes the logic for PPOM banners, hardcoding the `Warning` banners for any `reason`. `Error` and `Malicious` banners are still dependent on the reasons. [](https://codespaces.new/MetaMask/metamask-extension/pull/25058?quickstart=1) ## **Related issues** Fixes: [#1758](MetaMask/MetaMask-planning#1758) ## **Manual testing steps** 1. Open up metamask test-dapp. 2. Connect wallet 3. Open the console 4. Issue a transaction that approves USDT to unverified contract by invoking that transaction for example: ``` window.ethereum.sendAsync({ "method": "eth_sendTransaction", "params": [ { "from": "INSERT_YOUR_WALLET_ADDRESS", "to": "0xdac17f958d2ee523a2206206994597c13d831ec7", "data": "0x095ea7b3000000000000000000000000b208222089e9c48f3a0680b91be5a79d79ad429effffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff" } ], "timestamp": 1693229271999 }) ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
](https://codespaces.new/MetaMask/metamask-extension/pull/24037?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/25058?quickstart=1){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.