feat: improve blockaid error/warning copy

[segun]

Description

We should update content for:

when ppom returns warning as response

Related issues

Fixes: #1758

Manual testing steps

1. Add this custom network: https://base.drpc.org with chainId 8453
2. Trigger a transaction from the test dapp -- see error
3. For warning, you can edit the code to return a warning alert response and see the warning.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[jpuri]

I think we should keep above comment, the issue I think is when i18n message keys should not be used like above. That makes it hard for i18n tool to discover un-used keys etc.

[segun]

okay sure. I wasn't sure why the comment was there.

[jpuri]

LGTM except a small comment added.

[jpuri]

LGTM

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.58%. Comparing base (48a7969) to head (36e6a93).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #24037   +/-   ##
========================================
  Coverage    67.58%   67.58%           
========================================
  Files         1247     1247           
  Lines        48934    48934           
  Branches     12774    12774           
========================================
  Hits         33069    33069           
  Misses       15865    15865           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [32ff830]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1515 ± 684 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	78	609	160	122	59
		domContentLoaded	11	81	33	17	8
		load	65	3675	1515	1424	684
		domInteractive	11	80	33	17	8

Bundle size diffs [🚀 Bundle size reduced!]

• background: 0 Bytes (0.00%)
• ui: 22 Bytes (0.00%)
• common: -1 Bytes (-0.00%)

[metamaskbot]

Builds ready [36e6a93]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2039 ± 618 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	82	368	169	78	37
		domContentLoaded	14	71	29	14	7
		load	68	3338	2039	1286	618
		domInteractive	14	71	29	14	7

Bundle size diffs [🚀 Bundle size reduced!]

• background: 0 Bytes (0.00%)
• ui: 22 Bytes (0.00%)
• common: -1 Bytes (-0.00%)