Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robustify providerFromEngine callback type check #76

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Robustify providerFromEngine callback type check #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/providerFromEngine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ function providerFromEngine(engine: JsonRpcEngine): SafeEventEmitterProvider {
// handle both rpc send methods
provider.sendAsync = engine.handle.bind(engine);
provider.send = (req: JsonRpcRequest<string[]>, callback: VoidFunction) => {
if (!callback) {
throw new Error('Web3 Provider - must provider callback to "send" method');
if (typeof callback !== 'function') {
throw new Error('Must provide callback to "send" method.');
}
engine.handle(req, callback);
};
Expand Down