Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robustify providerFromEngine callback type check #76

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Robustify providerFromEngine callback type check #76

merged 1 commit into from
Mar 12, 2021

Conversation

rekmarks
Copy link
Member

Fixes #72

Checks that the callback provided to the send method of the provider object returned by providerFromEngine checks that the callback is a function, rather than just truthy.

@rekmarks rekmarks requested a review from a team as a code owner March 12, 2021 17:39
NiranjanaBinoy
NiranjanaBinoy approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rekmarks rekmarks merged commit aa70ced into master Mar 12, 2021
@rekmarks rekmarks deleted the providerFromEngine-type-check branch March 12, 2021 17:44
sambacha pushed a commit to sambacha/eth-json-rpc-middleware that referenced this pull request Mar 22, 2021
@rekmarks
Robustify providerFromEngine callback type check (MetaMask#76)
dd74050
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiranjanaBinoy NiranjanaBinoy NiranjanaBinoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve runtime type check in providerFromEngine send function
2 participants
@rekmarks @NiranjanaBinoy