Remove node-fetch
#190
Merged
Remove node-fetch
#190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
remove-node-fetch
branch
from
dce6b98
to
c876223
Compare
Merged
The package `node-fetch` has been removed, instead requiring that `fetch` be provided as an option for the fetch middleware. This might reduce our bundle size (depending on whether our bundler is smart enough to omit this package already; I'm not sure). It also eliminates a dependency that has been a source of security advisories in the past. We will probably want to add it back as a `devDependency` when we add tests for this middleware, but so far this middleware is not tested.
Gudahtt
force-pushed
the
remove-node-fetch
branch
from
01f609f
to
dd40dfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package
node-fetchhas been removed, instead requiring thatfetchbe provided as an option for the fetch middleware.This might reduce our bundle size (depending on whether our bundler is smart enough to omit this package already; I'm not sure). It also eliminates a dependency that has been a source of security advisories in the past.
We will probably want to add this or
isomorphic-fetchback as adevDependencywhen we add tests for this middleware, but so far this middleware is not tested.