Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove btoa #192

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Remove btoa #192

merged 1 commit into from
Feb 10, 2023

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Feb 10, 2023

The btoa function must now be passed in as a middleware option. This lets us remove an additional dependency, and makes this package less dependent upon Node.js or browser specific APIs.

@Gudahtt

This comment was marked as resolved.

Base automatically changed from remove-node-fetch to main February 10, 2023 18:17
The `btoa` function must now be passed in as a middleware option. This
lets us remove an additional dependency, and makes this package less
dependent upon Node.js or browser specific APIs.
@Gudahtt Gudahtt marked this pull request as ready for review February 10, 2023 18:57
@Gudahtt Gudahtt requested a review from a team as a code owner February 10, 2023 18:57
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants