Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added getAccounts suppressUnauthorized param #116

Merged
merged 15 commits into from
Apr 27, 2022
Merged

Added getAccounts suppressUnauthorized param #116

Changes from 2 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
626b462
Added getAccounts suppressUnauthorized param
shanejonas Mar 22, 2022
38286b8
Fixed linting
shanejonas Mar 22, 2022
daa9b2f
Update src/wallet.ts
rekmarks Mar 23, 2022
35e6616
Added unauthorized error when account is provided but is not returned…
shanejonas Mar 23, 2022
1dfdf28
Merge branch 'main' into added-getaccounts-suppress-param
shanejonas Apr 19, 2022
020af63
Added tests for unauthorized
shanejonas Apr 19, 2022
3de56e0
Update test/wallet.test.ts
shanejonas Apr 19, 2022
652eb0e
Update test/wallet.test.ts
shanejonas Apr 19, 2022
a817bf5
Update test/wallet.test.ts
shanejonas Apr 19, 2022
cfdd591
Update test/wallet.test.ts
shanejonas Apr 19, 2022
cc315dd
Fixed linting
shanejonas Apr 20, 2022
274985e
Fixed signTransaction test
shanejonas Apr 20, 2022
804d58a
Merge branch 'main' into added-getaccounts-suppress-param
shanejonas Apr 20, 2022
b3c4d20
Changed param to object
shanejonas Apr 20, 2022
68a161e
Merge branch 'added-getaccounts-suppress-param' of github.com:MetaMas…
shanejonas Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ interface TypedMessageParams extends MessageParams {
}

interface WalletMiddlewareOptions {
getAccounts: (req: JsonRpcRequest<unknown>) => Promise<string[]>;
getAccounts: (
req: JsonRpcRequest<unknown>,
suppressUnauthorized?: boolean,
shanejonas marked this conversation as resolved.
Show resolved Hide resolved
) => Promise<string[]>;
processDecryptMessage?: (
msgParams: MessageParams,
req: JsonRpcRequest<unknown>,
Expand Down Expand Up @@ -379,7 +382,7 @@ export function createWalletMiddleware({
): Promise<string> {
if (typeof address === 'string' && address.length > 0) {
// ensure address is included in provided accounts
rekmarks marked this conversation as resolved.
Show resolved Hide resolved
const accounts: string[] = await getAccounts(req);
const accounts: string[] = await getAccounts(req, false);
shanejonas marked this conversation as resolved.
Show resolved Hide resolved
const normalizedAccounts: string[] = accounts.map((_address) =>
_address.toLowerCase(),
);
Expand Down