Added getAccounts suppressUnauthorized param #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
requested changes
Mar 23, 2022
shanejonas
commented
Mar 23, 2022
Co-authored-by: Shane <jonas.shane@gmail.com>
… from getAccounts
mcmire
reviewed
Apr 19, 2022
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
…k/eth-json-rpc-middleware into added-getaccounts-suppress-param
Gudahtt
added a commit
that referenced
this pull request
Feb 10, 2023
The `suppressUnauthorized` option has been removed from the type signature of the `getAccounts` parameter accepted by the `wallet` middleware. This option was added in #116 to fix an extension bug, but it was never used in practice. The linked extension change used the wrong parameter name (`suppressUnauthorizedError`), so this was always unset. We didn't notice because it also wasn't needed to fix the bug; the `resemblesAddress` condition added in that same PR was sufficient.
Gudahtt
added a commit
that referenced
this pull request
Feb 10, 2023
The `suppressUnauthorized` option has been removed from the type signature of the `getAccounts` parameter accepted by the `wallet` middleware. This option was added in #116 to fix an extension bug, but it was never used in practice. The linked extension change used the wrong parameter name (`suppressUnauthorizedError`), so this was always unset. We didn't notice because it also wasn't needed to fix the bug; the `resemblesAddress` condition added in that same PR was sufficient.
Gudahtt
added a commit
that referenced
this pull request
Feb 10, 2023
The `suppressUnauthorized` option has been removed from the type signature of the `getAccounts` parameter accepted by the `wallet` middleware. This option was added in #116 to fix an extension bug, but it was never used in practice. The linked extension change used the wrong parameter name (`suppressUnauthorizedError`), so this was always unset. We didn't notice because it also wasn't needed to fix the bug; the `resemblesAddress` condition added in that same PR was sufficient.
Gudahtt
added a commit
that referenced
this pull request
Feb 10, 2023
The `suppressUnauthorized` option has been removed from the type signature of the `getAccounts` parameter accepted by the `wallet` middleware. This option was added in #116 to fix an extension bug, but it was never used in practice. The linked extension change used the wrong parameter name (`suppressUnauthorizedError`), so this was always unset. We didn't notice because it also wasn't needed to fix the bug; the `resemblesAddress` condition added in that same PR was sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rel MetaMask/metamask-extension#14126