This repository was archived by the owner on Nov 26, 2024. It is now read-only.
Hover & Pressed color updates #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 2 new colors: background.pressed (#FFF 2%) background.pressed (#FFF 8%) *[Ref] Hexadecimal color code for transparency Updated 4 colors: background.default.hover (grey700 --> #282B2E) background.default.pressed (grey700 --> #36383B) background.alternative.hover (grey750 --> #191B1D) background.alternative.pressed (grey750 --> #27292A)
Akatori-Design
changed the title
Akatori-Design
changed the title
Collaborator
Builds ready [d6a15fe]
|
/Light Added two new tokens - background.pressed (#000 2%) - background.pressed (#000 8%) Updated 4 colors - background.default.hover (grey030 --> #FAFAFA) - background.default.pressed (grey030 --> #EBEBEB) - background.alternative.hover (grey100 --> #EDEFF1) - background.alternative.pressed (grey100 --> #DFE0E2) /Dark Added 2 new colors: - background.pressed (#FFF 2%) - background.pressed (#FFF 8%) Updated 4 colors: background.default.hover (grey700 --> #282B2E) background.default.pressed (grey700 --> #36383B) background.alternative.hover (grey750 --> #191B1D) background.alternative.pressed (grey750 --> #27292A)
Collaborator
Builds ready [bce5af3]
|
Collaborator
Builds ready [56a5507]
|
garrettbear
previously approved these changes
Jun 28, 2023
brianacnguyen
previously approved these changes
Jun 28, 2023
Collaborator
georgewrmarshall
left a comment
georgewrmarshall
left a comment
There was a problem hiding this comment.
Nice work! Tiny update. Otherwise LGTM!
- searched each color value and made sure they aligned in figma, css, js
- checked storybook Theme Colors stories
georgewrmarshall
suggested changes
Jun 28, 2023
Collaborator
georgewrmarshall
left a comment
georgewrmarshall
left a comment
There was a problem hiding this comment.
Blocking till descriptions have been update
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
garrettbear
requested review from
brianacnguyen,
garrettbear and
georgewrmarshall
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Collaborator
Builds ready [0f6da58]
|
Collaborator
Builds ready [3493cd8]
|
Collaborator
Builds ready [5df5d47]
|
Collaborator
Builds ready [d758a8a]
|
Contributor
Author
|
sweet |
This was referenced Jun 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/ Light Theme
Added 2 new colors:
Updated 4 colors:
/ Dark Theme
Added 2 new colors:
Updated 4 colors: