Skip to content
This repository was archived by the owner on Nov 26, 2024. It is now read-only.

Conversation

@georgewrmarshall
Copy link
Collaborator

@georgewrmarshall georgewrmarshall commented Feb 10, 2022

Description

  • Updating some of the design token descriptions that were wrong
  • Adding HEX values to description for brand colors
  • Updating primary to blue400 for dark mode

Screenshots

Light theme

lightmode

Dark theme

darkmode

@georgewrmarshall georgewrmarshall marked this pull request as ready for review February 10, 2022 01:49
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner February 10, 2022 01:49
@georgewrmarshall georgewrmarshall self-assigned this Feb 10, 2022
@georgewrmarshall georgewrmarshall added color Tokens related to color documentation Improvements or additions to documentation labels Feb 10, 2022
@Cal-L Cal-L added the needs-design-review Needs designer review label Feb 10, 2022
Cal-L and others added 4 commits February 11, 2022 11:58
* Add issue template

* Prettify issue template
* Adding css stylesheet contaiing color design tokens

* Adding css path to build

Co-authored-by: Cal Leung <cleun007@gmail.com>
Co-authored-by: github-actions <github-actions@github.com>
@georgewrmarshall georgewrmarshall changed the title Updating some token descriptions that were wrong Updating tokens Feb 15, 2022
georgewrmarshall and others added 15 commits February 16, 2022 09:17
* Updating some token descriptions that were wrong

* Adding HEX values to descriptions and updating primary in dark mode

* Updating token descriptions for brand colors

* Adding secondary tokens to light theme

* Adding storybook and adding initial design token documentation

* Clean up

* Updating some linting issues

* Updating scripts

* Adding secondary colors to dark and updating muted for both light and dark

* Updating all muted values

* Adding storybook and adding initial design token documentation

* Clean up

* Updating some linting issues

* Updating all muted values

* Swapping background default and alternative in dark mode and updating border color to be slightly less darker

* Skip lib check

* Add license to package.json

* Updates to tokens and docs

* Restoring token json token from main

* Try to fix test but updating text

* Fix build error

Co-authored-by: Cal Leung <cleun007@gmail.com>
…k-design-tokens into token-description-fixes
@georgewrmarshall
Copy link
Collaborator Author

Some merge conflicts and other mistakes in this branch closing and creating new one

@georgewrmarshall georgewrmarshall deleted the token-description-fixes branch February 16, 2022 02:08
Akatori-Design added a commit that referenced this pull request Jun 22, 2023
- background.pressed (#5)
- background.pressed (#14)

Updated 4 colors
- background.default.hover (grey030 --> #FAFAFA)
- background.default.pressed (grey030 --> #EBEBEB)
- background.alternative.hover (grey100 --> #EDEFF1)
- background.alternative.pressed (grey100 --> #DFE0E2)
georgewrmarshall added a commit that referenced this pull request Jun 28, 2023
* Added two new tokens
- background.pressed (#5)
- background.pressed (#14)

Updated 4 colors
- background.default.hover (grey030 --> #FAFAFA)
- background.default.pressed (grey030 --> #EBEBEB)
- background.alternative.hover (grey100 --> #EDEFF1)
- background.alternative.pressed (grey100 --> #DFE0E2)

* Dark Theme updates

Added 2 new colors:

background.pressed (#FFF 2%)
background.pressed (#FFF 8%)
*[Ref] Hexadecimal color code for transparency

Updated 4 colors:

background.default.hover (grey700 --> #282B2E)
background.default.pressed (grey700 --> #36383B)
background.alternative.hover (grey750 --> #191B1D)
background.alternative.pressed (grey750 --> #27292A)

* Light & Dark theme updates & fixes

/Light
Added two new tokens
- background.pressed (#000 2%)
- background.pressed (#000 8%)

Updated 4 colors
- background.default.hover (grey030 --> #FAFAFA)
- background.default.pressed (grey030 --> #EBEBEB)
- background.alternative.hover (grey100 --> #EDEFF1)
- background.alternative.pressed (grey100 --> #DFE0E2)

/Dark
Added 2 new colors:
- background.pressed (#FFF 2%)
- background.pressed (#FFF 8%)

Updated 4 colors:
background.default.hover (grey700 --> #282B2E)
background.default.pressed (grey700 --> #36383B)
background.alternative.hover (grey750 --> #191B1D)
background.alternative.pressed (grey750 --> #27292A)

* add hover pressed code and fix alternativePressed

* Update src/figma/tokens.json

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update src/figma/tokens.json

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update src/figma/tokens.json

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update src/figma/tokens.json

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

---------

Co-authored-by: garrettbear <gwhisten@gmail.com>
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

color Tokens related to color documentation Improvements or additions to documentation needs-design-review Needs designer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants