This repository was archived by the owner on Nov 26, 2024. It is now read-only.
generated from MetaMask/metamask-module-template
-
Notifications
You must be signed in to change notification settings - Fork 15
Upgrading storybook to 6.5 #212
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,5 +18,10 @@ module.exports = { | |
| extends: ['@metamask/eslint-config-jest'], | ||
| }, | ||
| ], | ||
| ignorePatterns: ['!.eslintrc.js', '!.prettierrc.js', 'dist/'], | ||
| ignorePatterns: [ | ||
| '!.eslintrc.js', | ||
| '!.prettierrc.js', | ||
| 'dist/', | ||
| 'storybook-static/', | ||
| ], | ||
| }; | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Needed to add storybook static folder otherwise linting was failing |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,18 +22,18 @@ | |
| "src/css/" | ||
| ], | ||
| "scripts": { | ||
| "setup": "yarn install && yarn allow-scripts", | ||
| "test": "jest", | ||
| "test:watch": "jest --watch", | ||
| "prepublishOnly": "yarn build:clean && yarn lint && yarn test", | ||
| "lint:eslint": "eslint . --cache --ext js,ts", | ||
| "lint:misc": "prettier '**/*.json' '**/*.md' '!CHANGELOG.md' '**/*.yml' --ignore-path .gitignore", | ||
| "build": "tsc --project .", | ||
| "build-storybook": "build-storybook", | ||
| "build:clean": "rimraf dist && yarn build", | ||
| "lint": "yarn lint:eslint && yarn lint:misc --check", | ||
| "lint:eslint": "eslint . --cache --ext js,ts", | ||
| "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write", | ||
| "build:clean": "rimraf dist && yarn build", | ||
| "build": "tsc --project .", | ||
| "lint:misc": "prettier '**/*.json' '**/*.md' '!CHANGELOG.md' '**/*.yml' --ignore-path .gitignore", | ||
| "prepublishOnly": "yarn build:clean && yarn lint && yarn test", | ||
| "setup": "yarn install && yarn allow-scripts", | ||
| "storybook": "start-storybook -p 6006", | ||
| "build-storybook": "build-storybook" | ||
| "test": "jest", | ||
| "test:watch": "jest --watch" | ||
| }, | ||
| "dependencies": {}, | ||
| "devDependencies": { | ||
|
|
@@ -44,10 +44,10 @@ | |
| "@metamask/eslint-config-jest": "^9.0.0", | ||
| "@metamask/eslint-config-nodejs": "^9.0.0", | ||
| "@metamask/eslint-config-typescript": "^9.0.1", | ||
| "@storybook/addon-actions": "^6.4.18", | ||
| "@storybook/addon-essentials": "^6.4.18", | ||
| "@storybook/addon-links": "^6.4.18", | ||
| "@storybook/react": "^6.4.18", | ||
| "@storybook/addon-actions": "^6.5.10", | ||
| "@storybook/addon-essentials": "^6.5.10", | ||
| "@storybook/addon-links": "^6.5.10", | ||
| "@storybook/react": "^6.5.10", | ||
| "@types/jest": "^26.0.13", | ||
| "@typescript-eslint/eslint-plugin": "^4.21.0", | ||
| "@typescript-eslint/parser": "^4.21.0", | ||
|
|
@@ -60,7 +60,7 @@ | |
| "eslint-plugin-jsdoc": "^36.1.0", | ||
| "eslint-plugin-node": "^11.1.0", | ||
| "eslint-plugin-prettier": "^3.3.1", | ||
| "eslint-plugin-storybook": "^0.5.6", | ||
| "eslint-plugin-storybook": "^0.6.3", | ||
| "jest": "^26.4.2", | ||
| "node-fetch": "^2.6.0", | ||
| "prettier": "^2.2.1", | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updating packages and using prettier to change scripts to alphabetical order
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1 |
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding storybook-static/ directory to ignore linting