This repository was archived by the owner on Nov 26, 2024. It is now read-only.
Upgrading storybook to 6.5 #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Builds ready [7b30a4a]
|
Collaborator
Builds ready [e8b19a5]
|
georgewrmarshall
force-pushed
the
updating-storybook
branch
from
e8b19a5 to
393fa7f
Compare
georgewrmarshall
commented
Aug 8, 2022
| 'dist/', | ||
| 'storybook-static/', | ||
| ], | ||
| }; |
Collaborator
Author
There was a problem hiding this comment.
Needed to add storybook static folder otherwise linting was failing
Collaborator
Builds ready [393fa7f]
|
georgewrmarshall
force-pushed
the
updating-storybook
branch
from
393fa7f to
de69cdc
Compare
Collaborator
Builds ready [de69cdc]
|
georgewrmarshall
commented
Aug 8, 2022
| "eslint-plugin-storybook": "^0.6.3", | ||
| "jest": "^26.4.2", | ||
| "node-fetch": "^2.6.0", | ||
| "prettier": "^2.2.1", |
Collaborator
Author
There was a problem hiding this comment.
Updating packages and using prettier to change scripts to alphabetical order
georgewrmarshall
commented
Aug 8, 2022
| '!.eslintrc.js', | ||
| '!.prettierrc.js', | ||
| 'dist/', | ||
| 'storybook-static/', |
Collaborator
Author
There was a problem hiding this comment.
Adding storybook-static/ directory to ignore linting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrading storybook from
^6.4.18to^6.5.10because it includes a bunch of goodies.Manual testing steps
yarn setup && yarn storybookReferences
https://storybook.js.org/blog/storybook-6-5/#webpack-5-lazy-compilation-for-faster-startup