This repository was archived by the owner on Nov 26, 2024. It is now read-only.
Updating typography tests and some token json #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgewrmarshall
added
typography
Collaborator
Builds ready [ab1c9e2]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #144 made it evident that we do not have sufficient testing for the typography objects in the figma token json.
This PR updates tests to check against the typography style objects from the figma json rather than just checking the individual tokens(fontSize, fontFamily, letterSpacing, etc) that make up the typography styles.
It also includes one update to the letter spacing tokens for
S-Body-SM-BoldandS-Body-SMFixes: #146