This repository was archived by the owner on Nov 26, 2024. It is now read-only.
Fixing wrong token mappings & Naming Typo for Typography #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Builds ready [7b38924]
|
georgewrmarshall
force-pushed
the
typography-fix
branch
from
7b38924 to
6a5f559
Compare
Collaborator
Builds ready [6a5f559]
|
Collaborator
georgewrmarshall
left a comment
georgewrmarshall
left a comment
There was a problem hiding this comment.
Looks good. I have one question about themes below?
This was referenced May 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Naming Fix :
L-Heading-MD--->L-Heading-MDS-Heading-MD--->S-Heading-MD2. LineHeight mapping Fix :
S-textstyles are off by 1.3. FontWeight mapping Fix:
-Changed
S-Body-MD-Boldfontweight fromeuclid-circular-b-2(Regular) toeuclid-circular-b-1(Bold)See 🚩 in Typography Table at Notion
*Tokens mapped in Notion are the updated & correct ones