Skip to content

Conversation

@hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Oct 23, 2025

Explanation

Added actions for createNewVaultAndKeychain and createNewVaultAndRestore. These are meant to be consumed by the createNewMultichainAccountWallet method in the MultichainAccountService.

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Adds messenger actions and handlers for createNewVaultAndKeychain and createNewVaultAndRestore, and documents them in the changelog.

  • KeyringController:
    • Add action types KeyringControllerCreateNewVaultAndKeychainAction and KeyringControllerCreateNewVaultAndRestoreAction in src/KeyringController.ts.
    • Extend KeyringControllerActions union to include the new actions.
    • Register action handlers for ${name}:createNewVaultAndKeychain and ${name}:createNewVaultAndRestore.
  • Docs:
    • Update packages/keyring-controller/CHANGELOG.md under Unreleased to note the new actions.

Written by Cursor Bugbot for commit e424f6b. This will update automatically on new commits. Configure here.

@hmalik88 hmalik88 marked this pull request as ready for review October 23, 2025 14:30
@hmalik88 hmalik88 requested review from a team as code owners October 23, 2025 14:30
@hmalik88 hmalik88 merged commit 796d640 into main Oct 23, 2025
255 checks passed
@hmalik88 hmalik88 deleted the hm/add-keyring-actions branch October 23, 2025 16:22
Gudahtt added a commit that referenced this pull request Oct 24, 2025
…r/multichain-transactions-controller

* origin/main: (35 commits)
  feat: `JsonRpcEngineV2` (#6176)
  Release 641.0.0 (#6940)
  feat: Add transaction emulation actions (#6935)
  Release/640.0.0 (#6934)
  fix(core-backend): control randomness to fix flaky test (#6936)
  chore: Add `@metamask-previews/*` to NPM age gate exceptions (#6937)
  Release/639.0.0 (#6931)
  feat: make getCryptoApproveTransactionParams synchronous (#6930)
  feat: add new actions to `KeyringController` (#6928)
  feat: add `getAccounts` to `AccountsController` (#6927)
  chore: remove `Monad Mainnet` single call balance contract and add into account v4 (#6929)
  Release/638.0.0 (#6923)
  fix: Downgrade `multiformats` to `^9.9.0` to avoid ESM-only dependency (#6920)
  Release/637.0.0 (#6919)
  feat(account-tree-controller): add callbacks for hidden and pinned data (#6910)
  Release 636.0.0 (#6918)
  fix(core-backend): reconnection logic (#6861)
  fix:  Tx state listener and signature coverage (#6906)
  Release/635.0.0 (#6917)
  fix(base-controller): add TypeScript declaration file for legacy module resolution (#6915)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants