Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added missing package-level export for TransactionControllerOptions #4683

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix: Added missing package-level export for TransactionControllerOptions #4683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/transaction-controller/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export type {
TransactionControllerTransactionSubmittedEvent,
TransactionControllerUnapprovedTransactionAddedEvent,
TransactionControllerMessenger,
TransactionControllerOptions,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXED: Add missing package-level export for TransactionControllerOptions type.

I think we are exporting a new type from this package more than fixing something, although it is a fix in terms of how the package is aligned with others. Thoughts on making this an ADDED entry?

Related to this, do you think we can edit this directly in the Unreleased section of the CHANGELOG?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I think, it has another angle, it fixes something which was expected to be exported.

I believe, we can edit CHANGELOG at the time of release.

} from './TransactionController';
export {
HARDFORK,
Expand Down
Loading