fix: Added missing package-level export for TransactionControllerOptions #4683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikesposito
approved these changes
Sep 11, 2024
| @@ -22,6 +22,7 @@ export type { | |||
| TransactionControllerTransactionSubmittedEvent, | |||
| TransactionControllerUnapprovedTransactionAddedEvent, | |||
| TransactionControllerMessenger, | |||
| TransactionControllerOptions, | |||
There was a problem hiding this comment.
FIXED: Add missing package-level export for TransactionControllerOptions type.
I think we are exporting a new type from this package more than fixing something, although it is a fix in terms of how the package is aligned with others. Thoughts on making this an ADDED entry?
Related to this, do you think we can edit this directly in the Unreleased section of the CHANGELOG?
There was a problem hiding this comment.
Yeah. I think, it has another angle, it fixes something which was expected to be exported.
I believe, we can edit CHANGELOG at the time of release.
pedronfigueiredo
approved these changes
Sep 11, 2024
digiwand
approved these changes
Sep 11, 2024
kanthesha
deleted the
fix/package-level-export-transactioncontrolleroptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Added missing package-level export for
TransactionControllerOptionstype.References
@metamask/transaction-controllershould export theTransactionControllerOptionstype at the package level #4671Changelog
@metamask/transaction-controllerTransactionControllerOptionstype.Checklist