deps: upgrade from ethereumjs-util #3943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@types/bn.js@5.1.1 |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
legobeat
force-pushed
the
deps-ethereumjs
branch
from
d16a37f to
ee3f6f3
Compare
legobeat
commented
Feb 21, 2024
| "@metamask/utils": "^8.3.0", | ||
| "async-mutex": "^0.2.6", | ||
| "ethereumjs-util": "^7.0.10", | ||
| "ethereumjs-wallet": "^1.0.1", |
Contributor
Author
There was a problem hiding this comment.
Note: Updating to @ethereumjs/wallet (and thereby a transitive dependency on ethereumjs-util) breaks Node.js 16 support, hence blocked by #3611
legobeat
force-pushed
the
deps-ethereumjs
branch
from
ee3f6f3 to
ef140be
Compare
3 tasks
legobeat
force-pushed
the
deps-ethereumjs
branch
from
ef140be to
12a65dd
Compare
mcmire
reviewed
Feb 21, 2024
Contributor
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
Just a few things I noticed, but otherwise looks good.
legobeat
force-pushed
the
deps-ethereumjs
branch
from
12a65dd to
5dc92c0
Compare
legobeat
force-pushed
the
deps-ethereumjs
branch
2 times, most recently
from
ae7e3f3 to
69a88bb
Compare
lifted from assets-controller
TODO: see if safe to stop double-trimming leading as well as trailing zeroes in getTokenSymbol and thereby replace toUtf8 with something simpler.
…ask/utils and @ethereumjs/util
…tils and @ethereumjs/util
…util, ethereum-cryptography
…/utils equivalents
…til and @metamask/utils - test(keyring-controller): Update expected error message when importing invalid key
legobeat
force-pushed
the
deps-ethereumjs
branch
from
69a88bb to
8adba4f
Compare
3 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Legacy
ethereumjs-utilis used primarily for two things: its re-exportedbn.jsinstance and a handful of bytes/hex/string utility functions.BNdirectly frombn.jsinstead of viaethereumjs-util.ethereumjs-utillibrary functions with equivalent from@metamask/utilsif already availableadd0x/remove0xethereum-cryptographyfor crypto functions no longer available in@ethereumjs/utilTextEncoderawareness to test runtime ofcontroller-utils(needed for crypto hash function)@ethereumjs/util@^8.1.0for remainingethereumjs-utilimportsReferences
Changelog
@metamask/accounts-controllerethereumjs-utilwith@ethereumjs/utilandethereum-cryptography@metamask/assets-controllerethereumjs-utilwith@ethereumjs/utilandbn.js@metamask/controller-utilsethereumjs-utilwith@ethereumjs/util@metamask/gas-fee-controllerethereumjs-utilwithbn.js@metamask/keyring-controllerethereumjs-utilwith@ethereumjs/util@metamask/message-managerethereumjs-util@metamask/signature-controllerethereumjs-util@metamask/transaction-controllerethereumjs-utilwith@ethereumjs/utilandbn.js@metamask/user-operation-controllerethereumjs-utilwithbn.jsChecklist