feat: Network & Gas & Assets & Utils controllers update

[tommasini]

Description

• Network Controller updated to v^17.2.0

• Gas Fee Controller updated to v^13.0.0

• Controller utils v^8

• Assets Controllers v^26

• Updated the patch of Network Controller, now it adds an export a type

• Gas Fee Controller now uses NetworkController:networkDidChange event instead of NetworkController:stateChange event.

• Removed resolution for transaction controller and replaced it with a small change via patch

• Assets Controllers already with Reservoir changes of this PR

• Assets Controllers patch cleaner and smaller

• Token Detection Controller and Token Balances Controller updated on Engine and Engine Service since now they extend BaseController v2

• Added to the patch of assets controllers work around for TokenBalancesController and TokenRatesController listening the TokensController events wrongly since TokensController is not extending BaseControllerV2

• Added migration to reset contractBalances property of TokenBalancesController

• Changed on Amount and Confirm screen where contractBalances were used as BN to be converted to BN since now contractBalances property is now saving balances on hexadecimal string

Created a new core branch to follow up the assets-controllers version: patch/mobile-assets-controllers-26

Related issues

Fixes:

• https://github.com/MetaMask/mobile-planning/issues/1691
• https://github.com/MetaMask/mobile-planning/issues/1692
• https://github.com/MetaMask/mobile-planning/issues/1694
• https://github.com/MetaMask/mobile-planning/issues/1690

Manual testing steps

1. Sendflow Transaction On linea sepolia
2. Test dapp transaction On sepolia
3. Switch networks in general
4. Add custom network
5. add networks from popular list
6. Remove network
7. Add network throught dapp
8. Add tokens with auto detect feature, with token list, custom token fields and via dapp
9. Added nfts with auto detect NFTS, play around with display nft media and ipfs gateway toggles to check privacy is still working as expected. Also added nft with custom fields
10. Switched accounts when on dapp and check if permission systems is working (it should be able to switch accounts when switching dapp that have different accounts connected)

Screenshots/Recordings

Adding a custom network:

Screen.Recording.2024-05-08.at.16.24.54.mov

Playing around with tokens & multiple networks (auto detect, add from dapp, custom add and add from token list):

Screen.Recording.2024-05-08.at.16.14.27.mov

Screen.Recording.2024-05-08.at.16.17.05.mov

Dapp sepolia transaction:

Screen.Recording.2024-05-08.at.16.19.51.mov

Linea sepolia transcation:

Screen.Recording.2024-05-08.at.09.41.44.mov

NFT & privacy playground:

Screen.Recording.2024-05-08.at.15.57.02.mov

• Go to the test dapp and try deploying an ERC20 contract (tap create token) , deploy a collectible contract
• use a dapp to switch networks. Chainlist would work.
• edit gas before submitting a txn
  check this slack thread: https://consensys.slack.com/archives/C04GLB755TK/p1715772583995679?thread_ts=1715341470.231619&cid=C04GLB755TK

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
• - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ]

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3291839
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d89002f5-ee62-4e2e-9cfc-c66ad9dabdd5

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[Cal-L]

LGTM

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/assets-controllers@26.0.0	None	+5	1.29 MB	metamaskbot
npm/@metamask/gas-fee-controller@13.0.2	None	+6	826 kB	metamaskbot
npm/@metamask/network-controller@17.2.1	environment Transitive: network	+10	1.12 MB	metamaskbot
npm/@metamask/polling-controller@5.0.1	None	0	52.5 kB	metamaskbot

🚮 Removed packages: npm/@metamask/assets-controllers@18.0.0, npm/@metamask/gas-fee-controller@10.0.1, npm/@metamask/network-controller@15.2.0, npm/@metamask/polling-controller@1.0.2

View full report↗︎

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4282014
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5f69683d-70ab-417f-90cd-f3d880014161

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[christopherferreira9]

Looks good for SDK 👍

[Cal-L]

LGTM

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
76.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 586e3a3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e8dd589c-bc62-4a9c-b25f-9b33005e0096

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request