Skip to content

Remove braces from environment variables in Rose file creation mkdir commands - #207

Merged
chrisbillowsMO merged 3 commits into
mainfrom
201_fix_mkdir_env_vars
Feb 2, 2024
Merged

Remove braces from environment variables in Rose file creation mkdir commands#207
chrisbillowsMO merged 3 commits into
mainfrom
201_fix_mkdir_env_vars

Conversation

@chrisbillowsMO

@chrisbillowsMO chrisbillowsMO commented Feb 2, 2024

Copy link
Copy Markdown
Contributor

Closes #201.

PR creation checklist for the developer

  • Has <issue_number> above ☝️ been replaced with the issue number?
  • Has main been selected as the base branch?
  • Does the feature branch name follow the format <issue_number>_<short_description_of_feature>?
  • Does the text of the PR title exactly match with the text (not including the issue number) of the issue title?
  • Have appropriate reviewers been added to the PR (once it is ready for review)?
  • Has the PR been assigned to the developer(s)?
  • Have the same labels as on the issue (except for the good first issue label) been added to the PR?
  • Has the Climate Model Evaluation Workflow (CMEW) project been added to the PR?
  • Has the appropriate milestone been added to the PR?

Definition of Done for the developer

  • Does the change in this PR address the above issue / have all acceptance criteria been met?
  • Does the change in this PR follow the requirements in the wiki: Developer Guide (including copyrights)?
  • Have new tests related to the change been added?
  • Do all the GitHub workflow checks pass?
  • Do all the tests run locally and pass? (Note: the tests are not run by the GitHub workflow, see wiki: Run the tests locally)
  • Has the API documentation (e.g. docstrings in Python modules) related to the change been updated appropriately?
  • Has the user documentation (i.e. everything in the doc directory) related to the change been updated appropriately, including the Quick Start section?
  • Do the HTML pages render correctly? (See wiki: Build the documentation locally)

PR creation checklist for the reviewer

  • Has <issue_number> above ☝️ been replaced with the issue number?
  • Has main been selected as the base branch?
  • Does the feature branch name follow the format <issue_number>_<short_description_of_feature>?
  • Does the text of the PR title exactly match with the text (not including the issue number) of the issue title?
  • Have appropriate reviewers been added to the PR (once it is ready for review)?
  • Has the PR been assigned to the developer(s)?
  • Have the same labels as on the issue (except for the good first issue label) been added to the PR?
  • Has the Climate Model Evaluation Workflow (CMEW) project been added to the PR?
  • Has the appropriate milestone been added to the PR?

Definition of Done for the reviewer

  • Does the change in this PR address the above issue / have all acceptance criteria been met?
  • Does the change in this PR follow the requirements in the wiki: Developer Guide (including copyrights)?
  • Have new tests related to the change been added?
  • Do all the GitHub workflow checks pass?
  • Do all the tests run locally and pass? (Note: the tests are not run by the GitHub workflow, see wiki: Run the tests locally)
  • Has the API documentation (e.g. docstrings in Python modules) related to the change been updated appropriately?
  • Has the user documentation (i.e. everything in the doc directory) related to the change been updated appropriately, including the Quick Start section?
  • Do the HTML pages render correctly? (See wiki: Build the documentation locally)

@chrisbillowsMO chrisbillowsMO self-assigned this Feb 2, 2024
@chrisbillowsMO chrisbillowsMO added bug Something isn't working rose Anything related to Rose labels Feb 2, 2024
@chrisbillowsMO chrisbillowsMO added this to the v0.1.0 milestone Feb 2, 2024
@chrisbillowsMO
chrisbillowsMO marked this pull request as ready for review February 2, 2024 15:11

@mo-nabilbrice Nabil (mo-nabilbrice) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this done! All the tests pass and the rose gui has one less error now!

@ehogan Emma Hogan (ehogan) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks chrisbillowsMO! 🎉

@ehogan

Copy link
Copy Markdown
Member

Nabil (@mo-nabilbrice) please tick the remaining checkbox! 🥳

@chrisbillowsMO
chrisbillowsMO merged commit 374f3bb into main Feb 2, 2024
@chrisbillowsMO
chrisbillowsMO deleted the 201_fix_mkdir_env_vars branch February 2, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working rose Anything related to Rose

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove braces from environment variables in Rose file creation mkdir commands

3 participants