Remove braces from environment variables in Rose file creation mkdir commands

[chrisbillowsMO]

When braces are used around environment variables the Rose GUI reads this an error. The run itself is not effected but removing braces will clear the errors from Rose GUI.

This could possibly be done alongside #185

From Rose support:

It looks like the "${BRACES}" around the environment variable are the issue here, this diff makes the error go away:

diff --git a/rose-app.conf b/rose-app.conf
index e7061e2..c4806dd 100644
--- a/rose-app.conf
+++ b/rose-app.conf
@@ -5,5 +5,5 @@ default=install_env_file.sh
 ENV_SCRIPTS_TARGET_DIR=${CYLC_WORKFLOW_SHARE_DIR}/bin
 SITE=${SITE}
 
-[file:${ENV_SCRIPTS_TARGET_DIR}]
+[file:$ENV_SCRIPTS_TARGET_DIR]
 mode=mkdir

The braces aren't protecting you from anything here so can be safely dispensed of. I think the cause is that the Rose syntax permits "{suffixes}" within curly braces which are used to create "duplicate" entries and this looks like that syntax.

The command line tools are clearly unfazed by this but the GUI raises an error.

[ehogan]

This reminded me that I wanted to add this to the Wiki: Developer Guide, so I have done that, see these changes 😊