Conversation
- REST handler validates requestId, success, photoUrl (on success) - Builds typed PhotoResponse before passing to PhotoManager - Error payloads lenient (crash path), fall back to UNKNOWN_ERROR - PhotoManager.handlePhotoResponse now takes PhotoResponse, not any - No unvalidated data flows downstream to apps
Root cause: BackgroundTimer (react-native-nitro-bg-timer) dispatches callbacks via JSI at higher priority than RN's WebSocket onmessage events. After CONNECTION_ACK, the JS thread is busy with REST calls and UDP setup. The NitroTimer liveness check fires before queued onmessage callbacks can update lastMessageTime -> false timeout. Fix: - Use plain setInterval for liveness timers (same priority as onmessage) - Add client-side ping sender (2s interval, as originally spec'd in 034) - Increase liveness timeout from 4s to 8s BackgroundTimer still used for reconnect interval (needs to fire when backgrounded). Verified via BetterStack: server was sending display events every 0.4-1.5s but client never received them. 170/180 closes on dev were code 1000 (client-initiated). Pattern: connect -> 5s -> timeout -> 5s reconnect -> repeat. See: cloud/issues/034-ws-liveness/post-mortem.md (Feb 18 update)
This reverts commit 4ee4922.
…rors cloud/photo-request-errors Fix: reject photo request Promise immediately on error instead of 30s timeout
…ream-dedup cloud/transcription-stream-dedup
📋 PR Review Helper📱 Mobile App Build✅ Ready to test! (commit 🕶️ ASG Client Build⏳ Waiting for build... 🔀 Test Locallygh pr checkout 2079 |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying mentra-live-ota-site with
|
| Latest commit: |
076a586
|
| Status: | ⚡️ Build in progress... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.