Conversation
📋 PR Review Helper📱 Mobile App Build✅ Ready to test! (commit 🕶️ ASG Client Build✅ Ready to test! (commit 🔀 Test Locallygh pr checkout 2007 |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying prod-augmentos-account with
|
| Latest commit: |
f79a095
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://713c443b.augmentos-e84.pages.dev |
| Branch Preview URL: | https://fixes-32.augmentos-e84.pages.dev |
Deploying mentra-live-ota-site with
|
| Latest commit: |
f79a095
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://67ffa9d5.mentra-live-ota-site.pages.dev |
| Branch Preview URL: | https://fixes-32.mentra-live-ota-site.pages.dev |
Deploying mentra-store-dev with
|
| Latest commit: |
f79a095
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1b38c920.augmentos-appstore-2.pages.dev |
| Branch Preview URL: | https://fixes-32.augmentos-appstore-2.pages.dev |
Deploying dev-augmentos-console with
|
| Latest commit: |
f79a095
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0bc37157.dev-augmentos-console.pages.dev |
| Branch Preview URL: | https://fixes-32.dev-augmentos-console.pages.dev |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de3dd84328
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const unsubscribe = navigation.addListener("beforeRemove", (e) => { | ||
| // Fires when back gesture starts or back button is pressed | ||
| console.log("navigating back") | ||
| backFn?.() | ||
| }) |
There was a problem hiding this comment.
In focusEffectPreventBack, the iOS beforeRemove listener calls backFn but never calls e.preventDefault(), so the original back action still proceeds; on screens where backFn itself calls goBack() (for example via MiniAppDualButtonHeader), a single swipe-back can trigger two pops and skip an extra screen. This is user-facing on iOS whenever that callback performs navigation.
Useful? React with 👍 / 👎.
| const handleWebViewMessage = (event: any) => { | ||
| const data = event.nativeEvent.data | ||
| miniComms.handleWebViewMessage(data) | ||
| // miniComms.handleRawMessageFromMiniApp(packageName, data) | ||
| } |
There was a problem hiding this comment.
handleWebViewMessage reads event.nativeEvent.data but no longer forwards it, so messages posted by local mini apps never reach the native message bus. That breaks mini-app interactions that depend on bridge calls (e.g., core_fn/request events), because the payload is silently dropped at the WebView boundary.
Useful? React with 👍 / 👎.
| // Handle specific message types | ||
| this.handleMessage(message) | ||
| // this.handleMessageFromMiniApp(packageName, message) |
There was a problem hiding this comment.
handleRawMessageFromMiniApp successfully parses incoming JSON but never invokes handleMessageFromMiniApp, so every inbound message is only logged and then discarded. Even with WebView forwarding enabled, actions like core_fn and other message types will never execute.
Useful? React with 👍 / 👎.
2 participants
No description provided.