Initial project scaffolding #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
adrianchiris
commented
Aug 2, 2023
adrianchiris
commented
- Add github issue templates
- Add github workflows (build, test, lint, image push, codeql)
- Setup golangci-lint
- Setup mockery
- Implement stub application with basic functionality
- Add Dockerfile
- Add README and CONTRIBUTING doc
- Add various automations using Task
moshe010
reviewed
Aug 2, 2023
| return err | ||
| } | ||
|
|
||
| func folderExist(path string) error { |
There was a problem hiding this comment.
can you move folderExist to utils?
adrianchiris
force-pushed
the
initial-proj-scaffolding
branch
from
fda409b
to
a009a37
Compare
moshe010
approved these changes
Aug 3, 2023
ykulazhenkov
reviewed
Aug 3, 2023
ykulazhenkov
reviewed
Aug 3, 2023
adrianchiris
force-pushed
the
initial-proj-scaffolding
branch
from
a009a37
to
8d7b5ff
Compare
- Add github issue templates - Add github workflows (build, test, lint, image push, codeql) - Setup golangci-lint - Setup mockery - Implement stub application with basic functionality - Add Dockerfile - Add README and CONTRIBUTING doc - Add various automations using Task Signed-off-by: adrianc <adrianc@nvidia.com>
adrianchiris
force-pushed
the
initial-proj-scaffolding
branch
from
8d7b5ff
to
197f0fa
Compare
ykulazhenkov
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.