Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog and terminology tidy-up for AESCE #7313

Merged
merged 2 commits into from
Mar 18, 2023
Merged

Changelog and terminology tidy-up for AESCE #7313

merged 2 commits into from
Mar 18, 2023

Conversation

daverodgman
Copy link
Contributor

@daverodgman daverodgman commented Mar 17, 2023 •
edited
Loading

Description

Add missing changelog for #6918 and #6915; tidy-up use of terminology in source files.

Gatekeeper checklist

  • changelog provided
  • backport not required
  • tests not required

@daverodgman
Tidy up ARMCE terminology
f918d42 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
@daverodgman
Changelog for AESCE support
f992e6f 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
@daverodgman daverodgman added needs-review Every commit must be reviewed by at least two team members, component-crypto Crypto primitives and low-level interfaces needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review priority-very-high Highest priority - prioritise this over other review work size-xs Estimated task size: extra small (a few hours at most) labels Mar 17, 2023
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added approved Design and code approved - may be waiting for CI or backports single-reviewer This PR qualifies for having only one reviewer and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Mar 17, 2023
This was referenced Mar 17, 2023
Merged
Merged
@daverodgman daverodgman removed the needs-ci Needs to pass CI tests label Mar 18, 2023
@daverodgman daverodgman merged commit b937c92 into Mbed-TLS:development Mar 18, 2023
@daverodgman daverodgman deleted the aes-armv8-changelog branch March 18, 2023 14:33
@daverodgman daverodgman mentioned this pull request Mar 20, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-elliott-arm paul-elliott-arm paul-elliott-arm approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-crypto Crypto primitives and low-level interfaces priority-very-high Highest priority - prioritise this over other review work single-reviewer This PR qualifies for having only one reviewer size-xs Estimated task size: extra small (a few hours at most)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daverodgman @paul-elliott-arm @tom-cosgrove-arm