-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document (with examples) how to integrate a third-party driver with Mbed TLS #6915
Document (with examples) how to integrate a third-party driver with Mbed TLS #6915
Conversation
088dcdc
to
b1185a9
Compare
3fd8330
to
5d5e640
Compare
07aedf0
to
5e93e5c
Compare
/* | ||
* Interface of curve P-256 (ECDH and ECDSA) | ||
* | ||
* Author: Manuel Pégourié-Gonnard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this explicitly state copyright? @mpg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that you mention it, I think it should.
Please include a short readme in |
Done |
b0aef1a
to
54b4967
Compare
Reminder: we need to check the process defined in https://confluence.arm.com/display/OSS/Including+third+party+open+source+in+an+Arm+OSS+project Discussed with Aditya and agreed:
As per the checklist
When these are all concluded, please email OSRB as an FYI, linking them to this PR, and give them the opportunity to respond (let's say 2 weeks) before we merge. I don't expect they will request any changes or have any concerns, but best to keep them informed. |
49c3df0
to
a1fa583
Compare
Added the README from the p256-m repo in its original form. It should be noted however that it mentions scripts/files from the original repo that were not copied to mbedtls (should we edit these out?). I've also renamed the license file to LICENSE. The License section of the mbedtls project README has been updated so that it mentions both |
I think the simplest thing is just to add a short note at the top of the README that explains this. |
Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com>
Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com>
…on based on mbedtls_ctr_drbg Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com>
Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com>
Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com>
Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com>
Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com>
…date with upstream, plus other minor grammatical fixes. Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com>
Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com>
Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com>
Also check if p256-m is enabled in the config before including the contents of p256-m.c Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com>
Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com>
Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com>
a0ebef1
to
8225587
Compare
Had to make a few further changes to make the CI happy, but it's ready to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Really? This PR contains a non-trivial amount of code in @daverodgman I think you and I failed to notice, as reviewers, that this PR lacks testing. Two things should have alerted us:
Not the end of the world, but let's be more careful in the future. Tests are being added in #8032 now. |
Description
There is not much documentation on how a driver or software accelerator can be integrated alongside Mbed TLS. The proposed PSA Driver Interface, which aims to auto-generate driver wrappers, has only been partially implemented. It would be useful to have a guide in the interim which shows how to integrate drivers for operations for whom auto code-gen has not been implemented.
p256-m has been used as an example driver to show how a third party driver can be used with Mbed TLS.
TODO before merge
Needs preceding PR Add driver dispatch layer for raw key agreement, along with test call for transparent drivers. #6426 to be mergedDONENeeds preceding PR check_names.py: Compare identifiers in excluded files against symbols parsed by nm #6938 to be mergedDONENote:
all_u16-check_files
is expected to fail on PR-Head . This is because the version ofcheck_files.py
on this branch does not allow for box drawings characters. PR #6982 allows these characters and has been merged.all_u16-check_files
should pass on PR-Merge.Gatekeeper checklist