Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with nightly #4

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Fix build with nightly #4

merged 1 commit into from
Jun 20, 2023

Conversation

def-
Copy link

@def- def- commented Jun 20, 2023

error: failed to load source for dependency prost

Caused by:
Unable to update https://github.com/def-/prost#1dfee4ba

Caused by:
failed to update submodule prost-build/third-party/protobuf

Caused by:
failed to parse url for submodule prost-build/third-party/protobuf: git@github.com:protocolbuffers/protobuf

error: failed to load source for dependency `prost`

Caused by:
  Unable to update https://github.com/def-/prost#1dfee4ba

Caused by:
  failed to update submodule `prost-build/third-party/protobuf`

Caused by:
  failed to parse url for submodule `prost-build/third-party/protobuf`: `git@github.com:protocolbuffers/protobuf`
def- added a commit to def-/materialize that referenced this pull request Jun 20, 2023
Uses MaterializeInc/prost#4

error: failed to load source for dependency `prost`

Caused by:
  Unable to update https://github.com/MaterializeInc/prost#17cc373b

Caused by:
  failed to update submodule `prost-build/third-party/protobuf`

Caused by:
  failed to parse url for submodule `prost-build/third-party/protobuf`: `git@github.com:protocolbuffers/protobuf`

Caused by:
  relative URL without a base
def- added a commit to def-/materialize that referenced this pull request Jun 20, 2023
Uses MaterializeInc/prost#4

error: failed to load source for dependency `prost`

Caused by:
  Unable to update https://github.com/MaterializeInc/prost#17cc373b

Caused by:
  failed to update submodule `prost-build/third-party/protobuf`

Caused by:
  failed to parse url for submodule `prost-build/third-party/protobuf`: `git@github.com:protocolbuffers/protobuf`

Caused by:
  relative URL without a base
@def- def- requested review from benesch and teskje June 20, 2023 13:43
@benesch
Copy link
Member

benesch commented Jun 20, 2023

Going to merge this because we'll need it if we ever switch back to this fork. But hopefully we won't need it, and can stick with official prost releases going forward.

@benesch benesch merged commit 4303a9a into MaterializeInc:master Jun 20, 2023
@tisonkun
Copy link

tisonkun commented Jul 4, 2023

This is actually proposed at #2, lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants