-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nightly Rust build of prost #20041
Conversation
I think have to land MaterializeInc/prost#4 first. |
Looking at Cargo.toml, it seems like the reason we had to fork prost in the
first place has been fixed. Can you see if we could switch back to the
latest prost-build release instead? (crates.io dependencies don’t trigger a
pull of the submodule; the package itself bundles the submodule code.)
…On Tue, Jun 20, 2023 at 9:44 AM Dennis Felsing ***@***.***> wrote:
I think have to land MaterializeInc/prost#4
<MaterializeInc/prost#4> first.
—
Reply to this email directly, view it on GitHub
<#20041 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGXSIFY4LGONYVETVIRV6LXMGSL3ANCNFSM6AAAAAAZNJZT44>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
43ffd47
to
d7449ca
Compare
Seems to work, done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
36603ae
to
bc0d5c3
Compare
Actually my bad. prost v0.11.9 did not contain tokio-rs/prost#833, so we still have the same problem with prettyplease. I'm guessing prost v0.12.0 needs to be released to fix that first. |
bc0d5c3
to
43ffd47
Compare
I think just allow the duplicate dependency in deny.toml. Seems better than having to manage a bunch of patches for this. |
by going back to upstream prost version error: failed to load source for dependency `prost` Caused by: Unable to update https://github.com/MaterializeInc/prost#17cc373b Caused by: failed to update submodule `prost-build/third-party/protobuf` Caused by: failed to parse url for submodule `prost-build/third-party/protobuf`: `git@github.com:protocolbuffers/protobuf` Caused by: relative URL without a base
43ffd47
to
6f264c1
Compare
Uses MaterializeInc/prost#4
Motivation
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.