slt: Fix/disable broken explain plan #21771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def-
changed the title
|
Even worse, could this be flaky? Can we make sure the explain plan always returns the same result? Edit: This is not merge skew, but a flaky explain. I'm not sure if we can make the explain deterministic, will remove it for now. |
def-
force-pushed
the
pr-slt-fix
branch
2 times, most recently
from
9221c0d
to
baa9930
Compare
|
This test could definitely be flaky, as it's about timeouts. If it's breaking things, you (or I---whatever's easiest) can pull out the offending tests in cardinality.slt. |
def-
changed the title
…egg-timeouts also retry timeouts when talking to frontegg
|
@mgree If you stamp this PR it should auto-merge in a few minutes and disable the test for now. |
nrainer-materialize
approved these changes
Sep 15, 2023
nrainer-materialize
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came in via #21681
Explain plan changed inbetween to contain further information. I'll verify locally that this fixes it. Edit: Verified.
Test run: https://buildkite.com/materialize/tests/builds/63827#018a99b7-2ee9-48ec-9030-ce8a578dff26
Motivation
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.