Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also retry timeouts when talking to frontegg #21767

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

doy-materialize
Copy link
Contributor

Motivation

we're also seeing timeouts when making these api calls, not just connection errors

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:
    • no user facing changes

@doy-materialize doy-materialize merged commit 20cbade into main Sep 15, 2023
@doy-materialize doy-materialize deleted the doy-frontegg-timeouts branch September 15, 2023 16:39
def- pushed a commit to def-/materialize that referenced this pull request Sep 15, 2023
…egg-timeouts

also retry timeouts when talking to frontegg
def- pushed a commit to def-/materialize that referenced this pull request Sep 15, 2023
…egg-timeouts

also retry timeouts when talking to frontegg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants