check for old macros BOTH and EITHER

[ellensp]

Description

Users are continuing to have issue with using old Configs, updating the version number but not updating these macros.

The Error missing binary operator before token "(" is not obvious to the causal user

Added a pre flight check that searches Configuration.h and Configuration_adv.h for "BOTH(" and EITHER(" and errors with a much easier to understand error of the following:

ERROR: Old macro "BOTH()" or "EITHER()" found in your configuration files. Replace with "ALL()" and "ANY()" respectively and try again.

NOTE: cannot just search for "BOTH" as there is a comment with that string in it.

Added at the request of @thisiskeithb

Requirements

BOTH( or EITHER( in Configuration.h or Configuration_adv.h

Benefits

Less support requests

[thinkyhead]

We might as well have the script do the updates … and give a warning.

[thisiskeithb]

We might as well have the script do the updates … and give a warning.

Great! Now do all of Changes.h 😆

But really… The auto updating of config files is certainly neat, but I’m not sure if modifying them during a build is something we should be doing.

[ellensp]

I considered just updating the config and decided that wasn't the marlin way... the problem is there is no standard marlin way...

[thinkyhead]

The "Marlin way" is whatever works. Asking common end-users to muck with search-and-replace is more burdensome than modifying the file, warning them that changes were made, and then requiring them to build once more.

I do see this as a temporary patch until I have config migration completed. That work is coming along in various ways. (e.g., This spreadsheet has been set up to track all changes from version to version, and this will be applied to the migration code, which will work behind the scenes just modifying a config.ini file at each step.