Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] PR #27249 breaks build (Visual Code, Windows) #27252

Closed
1 task done
vovodroid opened this issue Jul 9, 2024 · 6 comments
Closed
1 task done

[BUG] PR #27249 breaks build (Visual Code, Windows) #27252

vovodroid opened this issue Jul 9, 2024 · 6 comments

Comments

@vovodroid
Copy link
Contributor

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

PR #27249 breaks build (Visual Code, Windows)

PS C:\DISK_D\3D\Marlin> platformio run -e mega1280
Processing mega1280 (board: megaatmega1280; platform: atmelavr@~4.0.1; framework: arduino)
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------Verbose mode can be enabled via `-v, --verbose` option
UnicodeDecodeError: 'charmap' codec can't decode byte 0x90 in position 96864: character maps to <undefined>:
  File "C:\Users\QQQ\.platformio\penv\Lib\site-packages\platformio\builder\main.py", line 167:
    env.SConscript(env.GetExtraScripts("pre"), exports="env")
  File "C:\Users\QQQ\.platformio\packages\tool-scons\scons-local-4.7.0\SCons\Script\SConscript.py", line 612:
    return _SConscript(self.fs, *files, **subst_kw)
  File "C:\Users\QQQ\.platformio\packages\tool-scons\scons-local-4.7.0\SCons\Script\SConscript.py", line 279:
    exec(compile(scriptdata, scriptname, 'exec'), call_stack[-1].globals)
  File "C:\DISK_D\3D\Marlin\buildroot\share\PlatformIO\scripts\preflight-checks.py", line 161:
    sanity_check_target()
  File "C:\DISK_D\3D\Marlin\buildroot\share\PlatformIO\scripts\preflight-checks.py", line 151:
    text = file.read()
  File "C:\Users\QQQ\.platformio\python3\Lib\encodings\cp1252.py", line 23:
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]

Bug Timeline

PR #27249

Expected behavior

No response

Actual behavior

No response

Steps to Reproduce

No response

Version of Marlin Firmware

Latest bugfix-2.1.x

Printer model

No response

Electronics

No response

LCD/Controller

No response

Other add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

No response

@ellensp
Copy link
Contributor

ellensp commented Jul 9, 2024

Please attach your configuration files.

@vovodroid
Copy link
Contributor Author

Please attach your configuration files.

Just default in bugfix-2.1.x branch - https://github.com/MarlinFirmware/Marlin/tree/bugfix-2.1.x/Marlin

My own build fails as well.

@ellensp
Copy link
Contributor

ellensp commented Jul 9, 2024

confirmed, oddly this doesn't happen on linux at all with same code and config, just windows...

@ellensp
Copy link
Contributor

ellensp commented Jul 9, 2024

Fixed. 8b81aae

@ellensp ellensp closed this as completed Jul 9, 2024
@ellensp
Copy link
Contributor

ellensp commented Jul 9, 2024

If anyone's interested

it breaks on the Ð in Configuration_adv.h from the line
//#define TOUCH_UI_UTF8_SCANDINAVIAN // Æ Ð Ø Þ æ ð ø þ

Copy link

github-actions bot commented Sep 7, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants