-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bed leveling issues #26819
Fix bed leveling issues #26819
Conversation
i have a question, for cartesian beds, is it better to have |
closing as sjasonsmith found a better fix. #26936 |
What about the MBL bug? |
oh darn, its a two parter... part 1 is addressed by #26936 |
Description
Two bugs
a while loop in line_to_destination_cartesian can loop forever.
Code has
while (cnt)
but variable cnt is a structure with a X and a Y component. This while does not end.Replaced with `while (cnt.x || cnt.y)now addressed by 🐛 Fix bool evalution of XYval and similar types #26936After ba08dcf
MESH_BED_LEVELING with SEGMENT_LEVELED_MOVES disabled fails to build.
Updated variable types to be unsigned.
Requirements
Bed leveling (UBL or MESH) with SEGMENT_LEVELED_MOVES disabled
Benefits
Works as expected
Related Issues