-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] IS_CARTHESIAN && DISABLED(SEGMENT_LEVELED_MOVES) wont compile error: conversion from 'XYval<unsigned char>' to non-scalar type 'XYval<signed char>' requested #26718
Comments
I did the same fix on my printer for the exact same error and flashed it successfully. Although are you sure you want MBL and not mean bilinear? |
I'm not sure, but my printer doesn't have any probe, and in the past I used
MBL for manual bed leveling. https://marlinfw.org/docs/gcode/G029-mbl.html
Dne út 23. 1. 2024 1:22 uživatel sargonphin ***@***.***>
napsal:
… I did the same fix on my printer for the exact same error and flashed it
successfully. Although are you sure you want MBL and not mean bilinear?
—
Reply to this email directly, view it on GitHub
<#26718 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF4AZAIEYY42Q7NXMFTMAODYP37CXAVCNFSM6AAAAABCFV7TGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBVGA3DSNJSGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Ah okay then bilinear is not for you in this case. From what I understand of the function, using unsigned should not be a problem. Give it a try and see if you can successfully save a mesh and reload it from EEPROM |
@thinkyhead Sorry to ping you, but could you look into this? Seems so that your commit ba08dcf created this issue. |
change and Builds without issue on the simulator Give it a try |
This will now be fixed in #26936 instead. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Did you test the latest
bugfix-2.1.x
code?Yes, and the problem still exists.
Bug Description
Something is wrong after this commit ba08dcf where is changed file mesh_bed_leveling.h and from this point the firmware cannot be compiled with settings IS_CARTESIAN && DISABLED(SEGMENT_LEVELED_MOVES)
I dont understand C, but my VSCode see error on line 66 in file mesh_bed_leveling.cpp - changing the line 66 from
xy_int8_t scel = cell_indexes(current_position), ecel = cell_indexes(destination);
to
xy_uint8_t scel = cell_indexes(current_position), ecel = cell_indexes(destination);
makes compilation possible, but I won't risk uploading it to my printer as I have no idea what it does.
Bug Timeline
No response
Expected behavior
No response
Actual behavior
No response
Steps to Reproduce
No response
Version of Marlin Firmware
not compiled, current bugfix-2.1.x
Printer model
No response
Electronics
No response
LCD/Controller
No response
Other add-ons
No response
Bed Leveling
MBL Manual Bed Leveling
Your Slicer
None
Host Software
None
Don't forget to include
Configuration.h
andConfiguration_adv.h
.Additional information & file uploads
No response
The text was updated successfully, but these errors were encountered: