Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G34 stepper locks #20091

Merged

Conversation

InsanityAutomation
Copy link
Contributor

Allow locking/unlocking individual steppers when multiple z steppers exist for manual movements.

@thinkyhead
Copy link
Member

Can you detail how it changes G34 / M422 and outline the new usage for the reader? The descriptions you supply may also be used in the website documentation. Thanks!

@sjasonsmith
Copy link
Contributor

I'm having a little trouble understanding how to use it.

I see that I would use something like G34 Z1 to lock and/or unlock Z1, but how do I tell it whether it is locked or unlocked?

I suppose I see two different workflows people might want with this:

  • Lock only one motor
  • Lock all motors except one

@sjasonsmith
Copy link
Contributor

but how do I tell it whether it is locked or unlocked?

I see, there is an S argument that isn't listed at the top of the G34 changes.

Lock only one motor (might be inverted?)
G34 Z3 S1

Lock all but one motor

G34 Z1 S1
G34 Z2 S1
G34 Z4 S1

Maybe it would make sense to expand L to allow both enabling and disabling all motors.

@thinkyhead
Copy link
Member

thinkyhead commented Nov 13, 2020

I tweaked it so that you can send L followed by a Z parameter on the same line. The meaning of L is unlock, so you'd be just specifying a single axis to lock. Since most of the time you probably want the opposite — all axes locked with one free — it might do to expand L so that L0 means unlock all and L1 (or L by itself) means "lock all." And then your Zn indicates the reverse of that.

@thinkyhead thinkyhead merged commit 1b0a5ab into MarlinFirmware:bugfix-2.0.x Nov 13, 2020
FhlostonParadise pushed a commit to FhlostonParadise/Marlin that referenced this pull request Nov 21, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Kannix2005 pushed a commit to Kannix2005/Marlin-1 that referenced this pull request Dec 7, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request Dec 9, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
tharts pushed a commit to tharts/Marlin that referenced this pull request Jan 6, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
dpreed pushed a commit to dpreed/Marlin_2.0.x that referenced this pull request Feb 5, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
kpishere pushed a commit to kpishere/Marlin that referenced this pull request Feb 19, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
@InsanityAutomation InsanityAutomation deleted the G34StepperLocks branch April 3, 2021 15:22
W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
chrisjenda pushed a commit to chrisjenda/Marlin that referenced this pull request Apr 8, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
chrisjenda pushed a commit to chrisjenda/Marlin that referenced this pull request Apr 11, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead added a commit to thinkyhead/Marlin that referenced this pull request Apr 28, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead added a commit to thinkyhead/Marlin that referenced this pull request Apr 29, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead added a commit that referenced this pull request Apr 30, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants