Split up pins.h to make pins more manageable #1416
Conversation
Hopefully this is helpful to organization and future expansion….
MarlinFirmware#1405 includes some changes to pins.h for a 4th extruder. This commit applies those changes. It also deals with a possible problem with SENSITIVE_PINS.
There’s no need to ask users to uncomment Max Endstop pins when they have them. These will be set to -1 later if the endstop option is disabled.
|
@MagoKimbra I Think this would be great. For languages_xxx.h, too. But have a look at sudar/Arduino-Makefile#249 and just google for . It does not work now with Arduino. It would break support for the Arduino IDE. There are discussions for years, but the collaborators of the Arduino project don't seem to see the point. :-( If you have a way to realize it, please tell. |
|
@thinkyhead Thanks for the great "pins_K8200.h". I think it's the right way, because you can see how easy it is to add a new board if it's identical to an other. And "pins_3Drag" shows how easy it is to add a board that is similar to an other. |
|
@CONSULitAS Yes i see... Ok!!! |
Hopefully this is helpful to organization and future expansion….
There’s no need to ask users to uncomment Max Endstop pins when they have them. These will be set to -1 later if the endstop option is disabled.
…nto cleanup_pins Pull for divergence.
thinkyhead
added
Needs: More Data
EEPROM data not aligned
Also fix analogInputToDigitalPin so it uses proper C hex notation
Hopefully this is helpful to organization and future expansion….
MarlinFirmware#1405 includes some changes to pins.h for a 4th extruder. This commit applies those changes. It also deals with a possible problem with SENSITIVE_PINS.
There’s no need to ask users to uncomment Max Endstop pins when they have them. These will be set to -1 later if the endstop option is disabled.
Also fix analogInputToDigitalPin so it uses proper C hex notation
…nto cleanup_pins Remote has diverged, so pull
Split up pins.h to make pins more manageable
|
It is nice, but all "pins_" files should be inside a folder "pins_mapping"... And the language files as well (may be "translation" folder).. The root folder is becoming a mess, too many files.. |
|
+1 — however, the dir should be “config” and the files should be named “system.h” (e.g. “ramps_13_EFB.h”, “ultimaker2.h”). I recommend “config” and not “pins” because I can see this evolving a bit. Can you imagine putting more things than pins there? I can. Given some of these are actual machines and some are motherboards, I see the machine people moving things like bed dimensions into the config files. In other words, there are hardware features and software options. I’d like to group the feature-related things together, and keep the options (what a person tweaks) to a minimum so that they are easy to distinguish. Admittedly the downside of this is that if a new feature or #define is added it must be spread out to all the config files. Just a thought… |
|
We can have different folders for different things.. Like "Pins_Mapping" for pins_*.h, "Machine_Specifics" for software configs related to specific machines and so one.. splitting things in folders are a good idea. |
|
@alexborro @bjmckenz Subfolders are not supported by Arduino's compiler, or we'd be using them already. |
|
Damn it.. What age do these arduino's guys live?
|
|
@alexborro To answer your question, have a look at this: arduino/Arduino#1004 :-))) |
pins_3DRAG.h: Fixed Z_ENABLE_PIN after split up pins.h in MarlinFirmware#1416 * @tinkyhead 62 is wrong for K8200 and should be 63 for 3Drag, too * @testers Could a 3Drag user please check? Thanks, @CONSULitAS tested with my K8200, working now
|
@alexborro @MagoKimbra Ok, so yes I discovered we can move things into subfolders. But, we have to "pretend" they are libraries. Here's the trick.
I just did this with the pins and language files ("MarlinLanguage"), and it worked great. It also needs some lines in the Makefile for command-line build.... |
|
I'm ok with such solution. And I think we can apply the same idea for thermistor tables as well. Cheers. Alex. 2015-02-24 4:18 GMT-03:00 Scott Lahteine notifications@github.com:
"Não é o mais forte da espécie que sobrevive, nem o mais inteligente. É Alex Borro |
|
I tried to download the marlin with the libraries folder, but when i compile do it error because it can not find the libraries MarlinLanguage.h. I have Arduino IDE 1.6.0 |
|
@MagoKimbra Hmm, I'm not too surprised. I closed my PR for the time-being because I got stuck on building with the Makefile. But it was working for me in the IDE, both 1.5.2 and 1.0.5. I will download 1.6 and try it later! |
|
I have a new update of |
Hopefully this is helpful to organization and future expansion….