Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break apart and clean up pins.h #1412

Closed
thinkyhead opened this issue Jan 25, 2015 · 3 comments
Closed

Break apart and clean up pins.h #1412

thinkyhead opened this issue Jan 25, 2015 · 3 comments

Comments

@thinkyhead
Copy link
Member

To make the Marlin root folder even more interesting (and to aid future development) I'm in the process of going through pins.h and breaking it up into separate files based on MOTHERBOARD name. Whether or not this produces a better final result is yet to be seen, but it's a good exercise to get a handle on the slightly messy state of pin assignments. It may end up making it easier to maintain pins and add new board support in the future, but for now it's more of an academic exercise to see whether pins files can be more consistently structured, to eliminate redundancies, and to make it's easier to find the pins you're looking for.

@alexborro
Copy link
Contributor

Think about that idea of a abstraction layer so we can associate a function
to a specific device.

Cheers.

Alex.

2015-01-25 0:45 GMT-02:00 Scott Lahteine notifications@github.com:

To make the Marlin root folder even more interesting (and to aid future
development) I'm in the process of going through pins.h and breaking it up
into separate files based on MOTHERBOARD name. Whether or not this produces
a better final result is yet to be seen, but it's a good exercise to get a
handle on the slightly messy state of pin assignments. It may end up making
it easier to maintain pins and add new board support in the future, but for
now it's more of an academic exercise to see whether pins files can be more
consistently structured, to eliminate redundancies, and to make it much
easier to find the pins you're looking for.


Reply to this email directly or view it on GitHub
#1412.

"Não é o mais forte da espécie que sobrevive, nem o mais inteligente. É
aquele que se adapta melhor as mudanças" ( Charles Darwin )

Alex Borro

@thinkyhead
Copy link
Member Author

First step was to split up the pins into separate files and clean them up. The result looks pretty good. The abstraction layer should be easier to conceive given this improvement. #1416

@thinkyhead thinkyhead added PR: Improvement Needs: More Data We need more data in order to proceed and removed Needs: More Data We need more data in order to proceed labels Jan 26, 2015
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants