Add penalty_type option to submission rules for percentage_of_mark penalties #7709

freyazjiner · 2025-10-23T19:08:27Z

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
This PR adds a penalty_type option to the late penalty submission rules, allowing instructors to choose whether late penalties are applied as a percentage of total assignment marks (default), a fixed number of points, or a percentage of each student’s earned mark.

Screenshots of your changes (if applicable)

⬇️

⬇️

⬇️

⬇️

⬇️

⬇️

Associated documentation repository pull request (if applicable)

See MarkUsProject/Wiki/pull/243 for updated instructor guide.

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type	Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)	X
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

I have performed a self-review of my changes.
- Check that all changed files included in this pull request are intentional changes.
- Check that all changes are relevant to the purpose of this pull request, as described above.
I have added tests for my changes, if applicable.
- This is required for all bug fixes and new features.
I have updated the project documentation, if applicable.
- This is required for new features.
If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

I have updated the project Changelog (this is required for all changes).
I have verified that the pre-commit.ci checks have passed.
I have verified that the CI tests have passed.
I have reviewed the test coverage changes reported by Coveralls.
I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

coveralls · 2025-10-23T21:56:34Z

Pull Request Test Coverage Report for Build 19217721017

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

78 of 78 (100.0%) changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 91.583%

Totals
Change from base Build 19081473154:	0.01%
Covered Lines:	42826
Relevant Lines:	45981

💛 - Coveralls

david-yz-liu

Hi @freyazjiner, I'm just leaving a few quick comments now (will wait for you to work on these and re-request a review).

You made a great point at our meeting today about the % sign needing to change for different units, and please feel free to implement this. Please use the term "marks" instead of "points", both in the dropdown and for replacing the %.
I've merged in #7697, which also contains a database migration. This is a bit tricky to resolve the merge correctly. Please do the following:
1. Rollback your current migration.
2. Update your branch from master.
3. Perform the rails db:migrate command again. This will both run the migration from that PR, plus your own.

In the UI, the penalty type dropdown is a bit misaligned. It should be aligned with the other text under the option label, so that it looks like it's part of the option configuration.

… marks

david-yz-liu

@freyazjiner looking good! I just left a few comments. Since this is a new feature that is user-facing, you should also update the documentation repo (look for the page that describes setting late penalties for assignments).

david-yz-liu · 2025-10-26T18:03:02Z

app/models/penalty_period_submission_rule.rb

    # submission Result
    return submission if submission.is_empty
    result = submission.get_original_result
+    unit = case self.penalty_type


I don't think this is necessary. The penalty_type validation should ensure that it's one of the expected values. You can just pass self.penalty_type directly to create the extra mark.

david-yz-liu · 2025-10-26T18:03:11Z

app/models/penalty_decay_period_submission_rule.rb

    # submission Result
    return submission if submission.is_empty
    result = submission.get_original_result
+    unit = case self.penalty_type


See comment below

david-yz-liu · 2025-10-26T18:03:58Z

app/models/submission_rule.rb

  accepts_nested_attributes_for :periods, allow_destroy: true
  validates_associated :periods
  validates :assignment, uniqueness: true
+  validates :penalty_type,


This is okay, but please override this validation in the two penalty-based submission rules to disallow nil. For those two rules we should always expect a non-nil penalty type.

david-yz-liu · 2025-10-26T18:10:50Z

app/assets/javascripts/create_assignment.js

  }
+  $("#penalty_type_selector_decay select, #penalty_type_selector_period select").on(
+    "change",
+    function () {


You can look at the jQuery documentation, but this function should be taking arguments for the event, from which you can obtain the new value of the select input. This is cleaner than doing another jQuery call to find the select element again.

david-yz-liu · 2025-10-26T18:11:50Z

config/locales/views/submission_rules/en.yml

+    penalty_type: Penalty type
+    penalty_types:
+      marks: Marks
+      percentage: Percentage


use the label "Percentage of assignment total"

david-yz-liu · 2025-10-26T18:12:03Z

config/locales/views/submission_rules/en.yml

+    penalty_types:
+      marks: Marks
+      percentage: Percentage
+      percentage_of_mark: Percentage of mark


and here use "Percentage of earned mark"

david-yz-liu

@freyazjiner nice work! I just left a few small comments.

But also I realized that we should update the student-facing messages that appear in the assignment settings when you view the settings as a student.

Currently, each SubmissionRule type has its own student-facing messages (see config/locales/views/submission_rules/en.yml). But there's only one set of messages per rule, and for the penalty rules they assume a "percentage" penalty type. Now that we're generalizing this, we should update these messages as well!

david-yz-liu · 2025-10-30T01:57:34Z

app/views/assignments/_form.html.erb

+          <%= t('submission_rules.penalty_type') %>:
+          <%= rule.select :penalty_type,
+                          [
+                            [t('submission_rules.penalty_types.percentage'), 'percentage'],


Oh, please use the ExtraMark constants here as well (not the string literals). Keep in mind that this is embedded Ruby code, so you have access to all of the backend models here!

david-yz-liu · 2025-10-30T01:57:43Z

app/views/assignments/_form.html.erb

+          <%= t('submission_rules.penalty_type') %>:
+          <%= rule.select :penalty_type,
+                          [
+                            [t('submission_rules.penalty_types.percentage'), 'percentage'],


Same comment as above

db/structure.sql

david-yz-liu

@freyazjiner I left a few more comments and did some manual testing. There's currently a bug where an instructor cannot change the penalty_type for a submission rule (create an assignment with a particular penalty type, then try updating the assignment to change the penalty type). Please make sure to test this carefully and fix this issue.

david-yz-liu · 2025-11-03T00:34:28Z

app/assets/javascripts/create_assignment.js

+      var selector = isDecay ? "#penalty_decay_periods" : "#penalty_periods";
+
+      if ($(event.target).val() === "points") {
+        $(selector + " .deduction-unit").text("marks");


The string "marks" should be internationalized

david-yz-liu · 2025-11-03T00:35:38Z

app/models/penalty_decay_period_submission_rule.rb

    overtime_hours = calculate_overtime_hours_from(Time.current, grouping)
    # Calculate the penalty that the grouping will suffer
    potential_penalty = calculate_penalty(overtime_hours)
+    type = case penalty_type


This is a bit more complicated than it needs to be. Write the _ right after overtime_message below, so that you can use #{penalty_type} directly in the interpolation string.

This comment applies to the other submission rule below.

david-yz-liu · 2025-11-03T00:36:32Z

app/views/assignments/_form.html.erb

+                          [
+                            [t('submission_rules.penalty_types.percentage'), ExtraMark::PERCENTAGE],
+                            [t('submission_rules.penalty_types.marks'), ExtraMark::POINTS],
+                            [t('submission_rules.penalty_types.percentage_of_mark'), ExtraMark::PERCENTAGE_OF_MARK]


List this option second, before the "Marks" option"

david-yz-liu · 2025-11-03T00:36:52Z

app/views/assignments/_form.html.erb

+                            [t('submission_rules.penalty_types.marks'), ExtraMark::POINTS],
+                            [t('submission_rules.penalty_types.percentage_of_mark'), ExtraMark::PERCENTAGE_OF_MARK]
+                          ],
+                          { selected: rule.object.penalty_type || 'percentage' } %>


Use ExtraMark::PERCENTAGE instead of the string literal

david-yz-liu · 2025-11-03T00:37:09Z

app/views/assignments/_form.html.erb

+                          [
+                            [t('submission_rules.penalty_types.percentage'), ExtraMark::PERCENTAGE],
+                            [t('submission_rules.penalty_types.marks'), ExtraMark::POINTS],
+                            [t('submission_rules.penalty_types.percentage_of_mark'), ExtraMark::PERCENTAGE_OF_MARK]


Same comments as above

david-yz-liu · 2025-11-03T00:38:42Z

config/locales/views/submission_rules/en.yml

    details_message_other: Thereafter, a deduction of %{deduction}% will be applied every %{interval} hours up to a maximum of %{hours} hours.
    extramark_description: Late submission (%{overtime_hours} hour(s)) resulted in automatic %{penalty_amount}% deduction.
-    overtime_message: The due date for this assignment has passed and you are now in a penalty period. You can make changes to your submission, but will have %{potential_penalty}% deducted from the final mark on this assignment.
+    overtime_message_percentage: The due date for this assignment has passed and you are now in a penalty period. You can make changes to your submission, but will have %{potential_penalty}% deducted from the final mark on this assignment.


After %{potential_penalty}% include the phrase "of the assignment total"

david-yz-liu · 2025-11-03T00:39:44Z

config/locales/views/submission_rules/en.yml

    extramark_description: Late submission (%{overtime_hours} hour(s)) resulted in automatic %{penalty_amount}% deduction.
-    overtime_message: The due date for this assignment has passed and you are now in a penalty period. You can make changes to your submission, but will have %{potential_penalty}% deducted from the final mark on this assignment.
+    overtime_message_percentage: The due date for this assignment has passed and you are now in a penalty period. You can make changes to your submission, but will have %{potential_penalty}% deducted from the final mark on this assignment.
+    overtime_message_percentage_of_mark: The due date for this assignment has passed and you are now in a penalty period. You can make changes to your submission, but will have %{potential_penalty}% deducted from your earned mark on this assignment.


Reword the last part to "%{potential_penalty}% of your earned mark deducted from the final mark on this assignment."

(This will align the wording better with the other two options

david-yz-liu · 2025-11-03T00:39:55Z

config/locales/views/submission_rules/en.yml

    details_message: Up to %{hours} hours after the due date, your grade will be reduced by %{deduction}%
    extramark_description: Late submission (%{overtime_hours} hour(s)) resulted in automatic %{penalty_amount}% deduction.
-    overtime_message: The due date for this assignment has passed and you are now in a penalty period. You can make changes to your submission, but will have %{potential_penalty}% deducted from the final mark on this assignment.
+    overtime_message_percentage: The due date for this assignment has passed and you are now in a penalty period. You can make changes to your submission, but will have %{potential_penalty}% deducted from the final mark on this assignment.


Same comments as above

david-yz-liu · 2025-11-03T00:40:24Z

spec/models/penalty_decay_period_submission_rule_spec.rb

        apply_rule
        rule_overtime_message = rule.overtime_message(grouping)
-        expected_overtime_message = I18n.t 'penalty_decay_period_submission_rules.overtime_message',
+        type = case rule.penalty_type


same comment as above

david-yz-liu · 2025-11-03T00:40:35Z

spec/models/penalty_period_submission_rule_spec.rb

        apply_rule
        rule_overtime_message = rule.overtime_message(grouping)
-        expected_overtime_message = I18n.t 'penalty_decay_period_submission_rules.overtime_message',
+        type = case rule.penalty_type


same comment as above

david-yz-liu

@freyazjiner okay all of the code changes look good, but there are still student-facing messages that need to be updated. Make sure you login as a student to view exactly what they are seeing for the different late penalties. Update all of the messages to incorporate penalty type, and update your PR description with screenshots of each type so it's clear that you've changed all of the necessary messages.

david-yz-liu

@freyazjiner okay things are looking great. I left a few small comments on the message wording.

However, I noticed one other bug when testing: in the grading view, the Summary tab on the right side shows the "Bonuses/Deductions" table. This table isn't showing the correct mark deduction for percentage_of_mark penalty type. I do see that the "Total Extra Marks" total below it is correct, as well as the "Total Mark" calculation. So it seems that just the table is the problem.

david-yz-liu · 2025-11-09T23:32:45Z

config/locales/views/submission_rules/en.yml

+    details_message_percentage_of_mark: Up to %{hours} hours after the due date, your grade will be reduced by %{deduction}% of your earned mark from the final mark on this assignment.
+    details_message_points: Up to %{hours} hours after the due date, your grade will be reduced by %{deduction} marks from the final mark on this assignment.
+    extramark_description_percentage: Late submission (%{overtime_hours} hour(s)) resulted in automatic %{penalty_amount}% deduction from assignment total.
+    extramark_description_percentage_of_mark: Late submission (%{overtime_hours} hour(s)) resulted in automatic %{penalty_amount}% deduction from earned mark .


Delete the space before the period

david-yz-liu · 2025-11-09T23:33:16Z

config/locales/views/submission_rules/en.yml

+    details_message_percentage: Up to %{hours} hours after the due date, your grade will be reduced by %{deduction}% of the assignment total from the final mark on this assignment.
+    details_message_percentage_of_mark: Up to %{hours} hours after the due date, your grade will be reduced by %{deduction}% of your earned mark from the final mark on this assignment.
+    details_message_points: Up to %{hours} hours after the due date, your grade will be reduced by %{deduction} marks from the final mark on this assignment.
+    extramark_description_percentage: Late submission (%{overtime_hours} hour(s)) resulted in automatic %{penalty_amount}% deduction from assignment total.


"from assignment total" -> "of the assignment total"

david-yz-liu · 2025-11-09T23:34:20Z

config/locales/views/submission_rules/en.yml

+    extramark_description_percentage: Late submission (%{overtime_hours} hour(s)) resulted in automatic %{penalty_amount}% deduction from assignment total.
+    extramark_description_percentage_of_mark: Late submission (%{overtime_hours} hour(s)) resulted in automatic %{penalty_amount}% deduction from earned mark .
+    extramark_description_points: Late submission (%{overtime_hours} hour(s)) resulted in automatic %{penalty_amount} marks deduction.
+    overtime_message_percentage: The due date for this assignment has passed and you are now in a penalty period. You can make changes to your submission, but will have %{potential_penalty}% of the assignment total deducted from the final mark on this assignment.


change "final mark" to "final grade"

david-yz-liu · 2025-11-09T23:34:32Z

config/locales/views/submission_rules/en.yml

+    extramark_description_percentage_of_mark: Late submission (%{overtime_hours} hour(s)) resulted in automatic %{penalty_amount}% deduction from earned mark .
+    extramark_description_points: Late submission (%{overtime_hours} hour(s)) resulted in automatic %{penalty_amount} marks deduction.
+    overtime_message_percentage: The due date for this assignment has passed and you are now in a penalty period. You can make changes to your submission, but will have %{potential_penalty}% of the assignment total deducted from the final mark on this assignment.
+    overtime_message_percentage_of_mark: The due date for this assignment has passed and you are now in a penalty period. You can make changes to your submission, but will have %{potential_penalty}% of your earned mark deducted from the final mark on this assignment.


change "final mark" to "final grade"

david-yz-liu · 2025-11-09T23:34:39Z

config/locales/views/submission_rules/en.yml

+    extramark_description_points: Late submission (%{overtime_hours} hour(s)) resulted in automatic %{penalty_amount} marks deduction.
+    overtime_message_percentage: The due date for this assignment has passed and you are now in a penalty period. You can make changes to your submission, but will have %{potential_penalty}% of the assignment total deducted from the final mark on this assignment.
+    overtime_message_percentage_of_mark: The due date for this assignment has passed and you are now in a penalty period. You can make changes to your submission, but will have %{potential_penalty}% of your earned mark deducted from the final mark on this assignment.
+    overtime_message_points: The due date for this assignment has passed and you are now in a penalty period. You can make changes to your submission, but will have %{potential_penalty} marks deducted from the final mark on this assignment.


change "final mark" to "final grade"

david-yz-liu · 2025-11-09T23:34:58Z

config/locales/views/submission_rules/en.yml

+    extramark_description_percentage: Late submission (%{overtime_hours} hour(s)) resulted in automatic %{penalty_amount}% deduction from assignment total.
+    extramark_description_percentage_of_mark: Late submission (%{overtime_hours} hour(s)) resulted in automatic %{penalty_amount}% deduction from earned mark.
+    extramark_description_points: Late submission (%{overtime_hours} hour(s)) resulted in automatic %{penalty_amount} marks deduction.
+    overtime_message_percentage: The due date for this assignment has passed and you are now in a penalty period. You can make changes to your submission, but will have %{potential_penalty}% of the assignment total deducted from the final mark on this assignment.


change "final mark" to "final grade"

david-yz-liu · 2025-11-09T23:35:00Z

config/locales/views/submission_rules/en.yml

+    extramark_description_percentage_of_mark: Late submission (%{overtime_hours} hour(s)) resulted in automatic %{penalty_amount}% deduction from earned mark.
+    extramark_description_points: Late submission (%{overtime_hours} hour(s)) resulted in automatic %{penalty_amount} marks deduction.
+    overtime_message_percentage: The due date for this assignment has passed and you are now in a penalty period. You can make changes to your submission, but will have %{potential_penalty}% of the assignment total deducted from the final mark on this assignment.
+    overtime_message_percentage_of_mark: The due date for this assignment has passed and you are now in a penalty period. You can make changes to your submission, but will have %{potential_penalty}% of your earned mark deducted from the final mark on this assignment.


change "final mark" to "final grade"

david-yz-liu · 2025-11-09T23:35:08Z

config/locales/views/submission_rules/en.yml

+    extramark_description_points: Late submission (%{overtime_hours} hour(s)) resulted in automatic %{penalty_amount} marks deduction.
+    overtime_message_percentage: The due date for this assignment has passed and you are now in a penalty period. You can make changes to your submission, but will have %{potential_penalty}% of the assignment total deducted from the final mark on this assignment.
+    overtime_message_percentage_of_mark: The due date for this assignment has passed and you are now in a penalty period. You can make changes to your submission, but will have %{potential_penalty}% of your earned mark deducted from the final mark on this assignment.
+    overtime_message_points: The due date for this assignment has passed and you are now in a penalty period. You can make changes to your submission, but will have %{potential_penalty} marks deducted from the final mark on this assignment.


change "final mark" to "final grade"

david-yz-liu · 2025-11-09T23:35:37Z

config/locales/views/submission_rules/en.yml

+    details_message_other_percentage: Thereafter, a deduction of %{deduction}% of the assignment total will be applied every %{interval} hours up to a maximum of %{hours} hours.
+    details_message_other_percentage_of_mark: Thereafter, a deduction of %{deduction}% of your earned mark will be applied every %{interval} hours up to a maximum of %{hours} hours.
+    details_message_other_points: Thereafter, a deduction of %{deduction}% marks will be applied every %{interval} hours up to a maximum of %{hours} hours.
+    extramark_description_percentage: Late submission (%{overtime_hours} hour(s)) resulted in automatic %{penalty_amount}% deduction from assignment total.


"from assignment total" -> "of the assignment total"

david-yz-liu · 2025-11-09T23:35:58Z

config/locales/views/submission_rules/en.yml

+    details_message_first_points: A deduction of %{deduction} marks will be applied every %{interval} hours up to %{hours} hours after the assignment is due.
+    details_message_other_percentage: Thereafter, a deduction of %{deduction}% of the assignment total will be applied every %{interval} hours up to a maximum of %{hours} hours.
+    details_message_other_percentage_of_mark: Thereafter, a deduction of %{deduction}% of your earned mark will be applied every %{interval} hours up to a maximum of %{hours} hours.
+    details_message_other_points: Thereafter, a deduction of %{deduction}% marks will be applied every %{interval} hours up to a maximum of %{hours} hours.


remove the % after %{deduction}

david-yz-liu

Nice work, @freyazjiner!

freyazjiner added 2 commits October 23, 2025 15:08

Add penalty_type to submission_rules

8eaab93

Add the penalty_type to controller and add tests

699d8f1

freyazjiner changed the title ~~Add penalty_type to submission_rules~~ Add penalty_type option to submission rules for percentage_of_mark penalties Oct 23, 2025

freyazjiner marked this pull request as ready for review October 23, 2025 21:31

freyazjiner requested a review from david-yz-liu October 23, 2025 22:05

freyazjiner marked this pull request as draft October 24, 2025 03:46

freyazjiner removed the request for review from david-yz-liu October 24, 2025 03:46

freyazjiner marked this pull request as ready for review October 24, 2025 13:13

freyazjiner requested a review from david-yz-liu October 24, 2025 13:13

david-yz-liu reviewed Oct 24, 2025

View reviewed changes

freyazjiner added 4 commits October 24, 2025 23:44

Add dynamic deduction unit based on penalty type and rename points to…

f764f71

… marks

Merge branch 'master' into implement-late-penalties

428fba2

Perform the database migration again

3a3697e

revert some renamings

dad5990

freyazjiner requested a review from david-yz-liu October 25, 2025 15:36

david-yz-liu reviewed Oct 26, 2025

View reviewed changes

freyazjiner added 3 commits October 27, 2025 18:08

use event parameter to prevent re-querying

3106f7c

cleaner approach to select better

dc9e17b

Merge branch 'master' into implement-late-penalties

32a8bed

freyazjiner requested a review from david-yz-liu October 28, 2025 01:49

david-yz-liu reviewed Oct 30, 2025

View reviewed changes

freyazjiner added 5 commits October 31, 2025 23:37

Add missing migration file for penalty_type column

bfd9502

Update the student-facing messages

4ab1b2b

Merge branch 'master' into implement-late-penalties

4bc68af

sort the key in alphabetical order

f394fb0

Add test case when penalty_type is by marks

af6ce69

freyazjiner requested a review from david-yz-liu November 2, 2025 14:40

david-yz-liu reviewed Nov 3, 2025

View reviewed changes

Merge branch 'master' into implement-late-penalties

76e3495

some minor improvements on keys

4c5fcc4

freyazjiner marked this pull request as draft November 5, 2025 02:53

freyazjiner added 2 commits November 5, 2025 01:10

fix the bug where an instructor cannot change the penalty_type

b73cdee

changed tests accordingly

c226f4a

freyazjiner marked this pull request as ready for review November 5, 2025 06:25

freyazjiner requested a review from david-yz-liu November 5, 2025 06:55

david-yz-liu reviewed Nov 5, 2025

View reviewed changes

freyazjiner requested review from david-yz-liu and removed request for david-yz-liu November 6, 2025 18:04

freyazjiner added 2 commits November 6, 2025 18:08

Update the late penalty message on both students and instructors sides

7066773

round the overtime hours to 2 decimal places

e1d95de

freyazjiner requested a review from david-yz-liu November 7, 2025 06:40

david-yz-liu reviewed Nov 9, 2025

View reviewed changes

freyazjiner added 2 commits November 9, 2025 20:21

Fix the bug inside the Bonuses/Deductions table

2476929

Delete the space

ca3b5d1

freyazjiner requested a review from david-yz-liu November 10, 2025 02:30

david-yz-liu approved these changes Nov 10, 2025

View reviewed changes

david-yz-liu linked an issue Nov 10, 2025 that may be closed by this pull request

Feature Request: Additional option for late penalty calculation #5565

Closed

david-yz-liu merged commit 485c3b0 into MarkUsProject:master Nov 10, 2025
7 checks passed

freyazjiner deleted the implement-late-penalties branch January 5, 2026 18:35

Add penalty_type option to submission rules for percentage_of_mark penalties #7709

Add penalty_type option to submission rules for percentage_of_mark penalties #7709

Uh oh!

Conversation

freyazjiner commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Type of Change

Checklist

Questions and Comments

Uh oh!

coveralls commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 19217721017

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

Uh oh!

david-yz-liu left a comment

Choose a reason for hiding this comment

Uh oh!

david-yz-liu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

david-yz-liu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

david-yz-liu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

david-yz-liu left a comment

Choose a reason for hiding this comment

Uh oh!

david-yz-liu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

freyazjiner commented Oct 23, 2025 •

edited

Loading

coveralls commented Oct 23, 2025 •

edited

Loading