Skip to content

Add missing page links to sitenav and workingWithSites overview#2307

Merged
tlylt merged 3 commits intoMarkBind:masterfrom
EssWhyy:fix-issue-2219
Jun 18, 2023
Merged

Add missing page links to sitenav and workingWithSites overview#2307
tlylt merged 3 commits intoMarkBind:masterfrom
EssWhyy:fix-issue-2219

Conversation

@EssWhyy
Copy link
Contributor

@EssWhyy EssWhyy commented Jun 13, 2023

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:
Fix #2219 (Add the "templates" page into the sitenav for more visibility)

Anything you'd like to highlight/discuss:
I have added the "templates" page to the sitenav and "Working With Sites" overview. I have also added the "Redirecting to 404" page section to the overview for consistency.

Testing instructions:

NA

Proposed commit message: (wrap lines at 72 characters)

Add missing page links to sitenav and workingWithSites overview


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@tlylt
Copy link
Contributor

tlylt commented Jun 16, 2023

I have also added the "Redirecting to 404" page section to the overview for consistency.

Do you mean "Adding Navigation Buttons" page?

Copy link
Contributor

@tlylt tlylt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the docs! To complete the inclusion of both Templates and Adding Navigation Buttons, will need you to also update their respective navigation button at the bottom of both pages.

E.g. this place:
image
image
Read this https://markbind-master.netlify.app/userguide/addingnavigationbuttons and see other examples for details.

(Also sorry for the delay!)

@EssWhyy
Copy link
Contributor Author

EssWhyy commented Jun 16, 2023

Oh yep my mistake, yep I was referring to the Adding Navigation Buttons section, and yeah ok I will add in the navigation buttons for both pages

@tlylt
Copy link
Contributor

tlylt commented Jun 18, 2023

@EssWhyy btw for the PR description, note that to have GitHub detect and close an issue for you, you will need to use one of the closing keywords: "Fixes #xxx" or "Resolves #xxx" (at least for now, until they make it more intelligent with their new AI features). Fix issue #2219 doesn't work (will need to remove the word "issue"), so Fix #2219 will work.

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Before:
image
After I edited the description:
image

Copy link
Contributor

@tlylt tlylt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlylt tlylt added this to the v4.1.1 milestone Jun 18, 2023
@tlylt tlylt merged commit 7ae6740 into MarkBind:master Jun 18, 2023
@tlylt
Copy link
Contributor

tlylt commented Jun 18, 2023

@all-contributors please add @EssWhyy for doc

@allcontributors
Copy link
Contributor

@tlylt

I've put up a pull request to add @EssWhyy! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the "templates" page into the sitenav for more visibility

2 participants