Convert Template function to class

[lhw-1]

What is the purpose of this pull request?

• Documentation update
• Bug fix
• Feature addition or enhancement
• Code maintenance
• DevOps
• Improve developer experience
• Others, please explain:

Overview of changes:

Resolves #2147.

Converts the Template function inside packages/core/template/template.js into a class.

This also simplifies the migration process for template.js into TypeScript in #2143.

Anything you'd like to highlight/discuss:

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)
Convert Template function to class

---

Checklist: ☑️

• Updated the documentation for feature additions and enhancements
• Added tests for bug fixes or features
• Linked all related issues
• No unrelated changes

[tlylt]

Interesting changes proposed!

Curious if there are opportunities here to improve the code further. For example, I wonder whether template.js really needs to be in this folder, or perhaps it is more suited in the Site folder. What do you think?

[lhw-1]

Curious if there are opportunities here to improve the code further. For example, I wonder whether template.js really needs to be in this folder, or perhaps it is more suited in the Site folder. What do you think?

On one hand, I think keeping template.js in the template folder makes sense since this is acting as a sort of "interface" for other files to create and initialize a template (though only Site/index.js is doing that right now).

But on the other hand, I also see the benefit in moving it over to the Site folder to (1) keep the JavaScript / TypeScript files all in once place (within src), and (2) since Site contains the files for initializing a MarkBind site / converting to a MarkBind site, it makes sense that we should have the Template class within this folder. And of course, the only file using the Template function / class right now is Site/index.js, which is one more point towards moving template.js to the Site folder.

Yes, I think moving it over may make more sense than keeping it where it currently is.

[lhw-1]

Update in 931271a:

template.js has been moved from packages/core/template/ to packages/core/src/Site/ as per the suggestion from @tlylt & the following discussion.

As the template files reside in another directory outside packages/core/src/Site, an additional correction to the path needed to be declared here. I am wondering if it would be a good idea to additionally move all the template files into the packages/core/src/Site folder to make it more direct, or if it would make more sense to keep the template in a separate folder as is currently being done. I would appreciate thoughts on this matter as I am uncertain if this makes sense 👍

[tlylt]

I am wondering if it would be a good idea to additionally move all the template files into the packages/core/src/Site folder to make it more direct, or if it would make more sense to keep the template in a separate folder as is currently being done. I would appreciate thoughts on this matter as I am uncertain if this makes sense 👍

I think leaving them there is fine, because of how they are used and also that in the future, that folder can potentially grow further in the event that we increase the number of templates supported.

As for the shift of template.js I was wondering if that causes any cyclic dependency, which doesn't seem to be the case so we should be good.

Lastly, I don't like how we have a "pass-through" method initSite that simply calls new Template().init, which feels like a red flag in the class design. Might need further refactoring in the future.

LGTM.