Migrate template to TypeScript#2143
Merged
raysonkoh merged 2 commits intoMarkBind:masterfrom Feb 13, 2023
Merged
Conversation
lhw-1
changed the title
This was referenced Feb 8, 2023
lhw-1
force-pushed
the
1913-typescript-template
branch
from
2a80042 to
ad4dba8
Compare
lhw-1
force-pushed
the
1913-typescript-template
branch
from
ad4dba8 to
1dcef01
Compare
lhw-1
changed the title
jovyntls
approved these changes
Feb 13, 2023
Contributor
jovyntls
left a comment
jovyntls
left a comment
There was a problem hiding this comment.
LGTM! TS migration is going well 🎊
raysonkoh
force-pushed
the
1913-typescript-template
branch
from
e4570fd to
a20ef61
Compare
Contributor
|
I think |
Contributor
|
Yea I think I general there needs to be some cleanup after the migration (which will hopefully be done soon) and marking suitable functions as private should be one aspect. The other migration PRs have not been focusing on this aspect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Part of #1913.
Migrates
packages/core/template/template.jsto TypeScript following the workflow specified here.This PR also builds on the changes made in PR #2148.
Overview of changes:
Anything you'd like to highlight/discuss:
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Checklist: ☑️