-
Couldn't load subscription status.
- Fork 16
Adding options.json #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'd prefer this be an "options" key within game.json |
This might be another good topic for a group discussion in the dev channel to see what everyone thinks. Original intent for game.json was to have meta things for the game, and have collections of standalone things go elsewhere. Which I realize means that starting items might be in the wrong place, too. 😄Reasoning behind limiting game.json to meta things would be to limit the complexity and purpose of the file, so each JSON is mostly in charge of describing one type of thing. |
|
My two main questions when looking at this PR are:
Or, to put the questions more simply: |
|
reposting this because it's in a resolved conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most minor of changes. Rest looks great 😃
As asked multiple times a way to modify the options
Instead of adding the parameters everywhere its possible to create options, I regrouped those and the ability to create options in a new options.json
why a option.json?
What's included in options.json:
Old description bellow