After options defined use dataclass #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silasary
reviewed
Dec 5, 2024
|
Everything else looks fine other than the thing about more clear examples. Making a note that we'll (obviously) want to mention that this is a breaking change when it goes to Unstable. |
silasary
approved these changes
Dec 7, 2024
Co-authored-by: Katelyn Gigante <clockwork.singularity@gmail.com>
FuzzyGamesOn
approved these changes
Dec 8, 2024
silasary
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on discord in the thread for pr #54 https://discord.com/channels/1097532591650910289/1311063001469812807
this make after_options_defined use the dataclass to stop dev from adding options there.