Per Classification Count aka Item types config not just for hooks devs #161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when I made #148 I had the idea to make the item config that are currently hook only be available to non-hook devs.
What this PR does exactly is that it adds the
classification_countproperties to items.json that let devs set custom counts for each ItemClassification via the existing hook-only items_config that I tweaked just a bit to work with string version of ints and support multi classification keys using the+characterexample:
{ "name": "Jump upgrade", "classification_count": {"useful + progression": 1, "useful": 1}, }This would create a copy of the "Jump upgrade" item with both useful and progression classification and another just useful
Complex Count bypasses some of the other properties ("count" and any regular classification properties (eg. "progression"))
This forced me to fix some of the datavalidations that failed when "progression" is not included