Skip to content

Conversation

@nicopop
Copy link
Contributor

@nicopop nicopop commented May 1, 2025

for a manual im doing I decided to use the before_create_items_all hook, but using any dict would fail
After fixing that I decided to test everything the comments says should work and thus found that the binary version mentionned in the comments also do not work

Here is what the comments looks like for the hooks currently:

# This hook allows you to access the item names & counts before the items are created. Use this to increase/decrease the amount of a specific item in the pool
# Valid item_config key/values:
# {"Item Name": 5} <- This will create qty 5 items using all the default settings
# {"Item Name": {"useful": 7}} <- This will create qty 7 items and force them to be classified as useful
# {"Item Name": {"progression": 2, "useful": 1}} <- This will create 3 items, with 2 classified as progression and 1 as useful
# {"Item Name": {0b0110: 5}} <- If you know the special flag for the item classes, you can also define non-standard options. This setup
#       will create 5 items that are the "useful trap" class

before 9fb61d1 only the first example worked
before 3896093 the last example wouldnt work

I decided to change from the predefined dict of ItemClassification to just calling ItemClassification itself since its simpler and is more future proof if base AP add a new classification later or something
and while at it I just let devs provide the ItemClassification directly in a2b66dd

@nicopop nicopop requested review from FuzzyGamesOn and axxroytovu May 1, 2025 20:44
@nicopop nicopop self-assigned this May 1, 2025
@nicopop nicopop requested a review from axxroytovu May 3, 2025 21:27
@silasary silasary merged commit d9c50a2 into main May 6, 2025
@nicopop nicopop deleted the fix-before_create_items_all branch May 13, 2025 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants