Fix before_create_items_all hook #148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for a manual im doing I decided to use the before_create_items_all hook, but using any dict would fail
After fixing that I decided to test everything the comments says should work and thus found that the binary version mentionned in the comments also do not work
Here is what the comments looks like for the hooks currently:
before 9fb61d1 only the first example worked
before 3896093 the last example wouldnt work
I decided to change from the predefined dict of ItemClassification to just calling ItemClassification itself since its simpler and is more future proof if base AP add a new classification later or something
and while at it I just let devs provide the ItemClassification directly in a2b66dd